From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 431f8ff1e38: * lisp/imenu.el: Support more values for imenu-flatten (bug#70846) Date: Tue, 13 Aug 2024 21:41:14 -0400 Message-ID: References: <171558357066.26019.9766615061719600757@vcs2.savannah.gnu.org> <20240513065931.0D83AC12C31@vcs2.savannah.gnu.org> <86v83hwxjs.fsf@mail.linkov.net> <86ikzhq6ja.fsf@mail.linkov.net> <86o798x5hz.fsf@gnu.org> <86bk572e6a.fsf@mail.linkov.net> <861q62pb8y.fsf@mail.linkov.net> <864jayjd8u.fsf@gnu.org> <86le49ymsl.fsf@mail.linkov.net> <86msoo4cf3.fsf@mail.linkov.net> <865xv9ugjx.fsf@mail.linkov.net> <867cffdsp8.fsf@mail.linkov.net> <86ttgs78eu.fsf@mail.linkov.net> <86msmj9adm.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33430"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eshel Yaron , Eli Zaretskii , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 14 03:42:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1se31b-0008ZU-BW for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Aug 2024 03:42:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1se30t-0007Z9-Jn; Tue, 13 Aug 2024 21:41:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se30q-0007Yx-Au for emacs-devel@gnu.org; Tue, 13 Aug 2024 21:41:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se30o-0002aM-LB; Tue, 13 Aug 2024 21:41:19 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E7181100061; Tue, 13 Aug 2024 21:41:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1723599675; bh=+76++fWVTMO5uqlNJBo0DE6znG1Ta0RoHE5r7Y2q5+o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EB2Gq6ctXqCauhmJN1g7BMDAw6TgvVVqdNsDFPl+40ZSA1aDig8P9VrZprBEg//Cv 2C+aEZvU2Dw10QXG9wdq0B2K0v43LgVLzXbnQ/dzVNN9As9XOhqx0ZCr+phmbDr+dt x8t+LcUIV82LoF4pk/SenKP9vomq+MlaxCWGYZ+xzvxLt64DP0EyE0/e99yfKL+UUX sJQfUe8isNEzKZi7+ira877p1eRzDQd5Dlt2Q4HlQogV7QR1uIc5MsVrKfJhBcwpsd EGdSVdxPoTt7yb7ne2lSeTTMkD16XxA9Utxli+X9iKDXqsrT1UpZyjtOR3n8QgXWfh 7rgCwddnShmGg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 74591100035; Tue, 13 Aug 2024 21:41:15 -0400 (EDT) Original-Received: from pastel (unknown [216.154.9.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4256F1202C7; Tue, 13 Aug 2024 21:41:15 -0400 (EDT) In-Reply-To: <86msmj9adm.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 14 Jul 2024 20:00:37 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322724 Archived-At: >> What I would suggest is to ensure completion candidates are unambiguous >> as strings rather than relying on text properties. Namely: > Unfortunately, that'd be a step back. Maybe at least we could document > limitations that annotations work only by selection. How about we make them unambiguous by adding text *at the end* (and only if there's ambiguity)? The completion code assumes in all kinds of places that the same text means the same thing, so using the same text to mean different completion choices will get you in trouble in all kinds of corner (and not so corner) cases. Stefan