From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Add M-x occur to the menu-bar Date: 28 Jan 2004 09:30:30 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <3F69E6FF.9050702@yahoo.com> <4n8yjto16h.fsf@collins.bwh.harvard.edu> <4nisixjibl.fsf@collins.bwh.harvard.edu> <20040127230323.GB5407@fencepost> <4n7jzc919v.fsf@collins.bwh.harvard.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1075300696 14469 80.91.224.253 (28 Jan 2004 14:38:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 28 Jan 2004 14:38:16 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Jan 28 15:38:08 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AlqpU-0002lu-00 for ; Wed, 28 Jan 2004 15:38:08 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AlqpU-0002Pf-00 for ; Wed, 28 Jan 2004 15:38:08 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Alqj8-00025c-Ic for emacs-devel@quimby.gnus.org; Wed, 28 Jan 2004 09:31:34 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1Alqif-00024g-MO for emacs-devel@gnu.org; Wed, 28 Jan 2004 09:31:05 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Alqi9-0001zF-Ia for emacs-devel@gnu.org; Wed, 28 Jan 2004 09:31:04 -0500 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Alqi8-0001yd-V5 for emacs-devel@gnu.org; Wed, 28 Jan 2004 09:30:33 -0500 Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 1A821210AF; Wed, 28 Jan 2004 09:30:31 -0500 (EST) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id CE7CE8C6F9; Wed, 28 Jan 2004 09:30:30 -0500 (EST) Original-To: Ted Zlatanov In-Reply-To: <4n7jzc919v.fsf@collins.bwh.harvard.edu> Original-Lines: 23 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=0, requis 5) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19526 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19526 > 1) next-error does not support the occur mode, which was what started > the discussion in the firts place. I tried to fix this with > minimum changes to the Emacs sources. Minimizing the amount of changes is a worthy goal but it should not take precedence over the goals of: - consistent behavior - maintainability What this means is that it would be better to integrate the support for occur and the support for grep and compile rather than add a layer on top of the support for grep and compile. That doesn't mean it has to be 100% integration, but `next-error' could pay attention to a variable like `compile-error-forward-function' or something like that which occur-mode could set buffer-locally. The idea is to keep as much of the code together: at least the code that selects and displays the relevant buffer should be shared, IMO. > 2) next-error is IMHO a bad name for a function that finds the next > match in grep mode, and the next occurrence in occur mode. That's probably tru. If you can come up with a better name, maybe we can change it. I don't find dwim-next to be much btter. Stefan