From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Finding the source of Change Log entries Date: Wed, 27 Aug 2008 22:03:22 -0400 Message-ID: References: <48787A1F.1080105@gmx.at> <873amfm9xj.fsf@stupidchicken.com> <86y7443784.fsf@lifelogs.com> <87y744jfnc.fsf@jurta.org> <6161f3180807142323w75acebb1m503d7754a5500cfa@mail.gmail.com> <87d4lf8n8h.fsf@jurta.org> <863ambxkl8.fsf@lifelogs.com> <87lk027umv.fsf@jurta.org> <86r693l2u5.fsf@lifelogs.com> <87wsi6gc37.fsf@jurta.org> <868wuii9t7.fsf@lifelogs.com> <86y72igorf.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1219889025 11344 80.91.229.12 (28 Aug 2008 02:03:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Aug 2008 02:03:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 28 04:04:38 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYWsA-0008LG-Nl for ged-emacs-devel@m.gmane.org; Thu, 28 Aug 2008 04:04:31 +0200 Original-Received: from localhost ([127.0.0.1]:45678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYWrC-0002p0-K3 for ged-emacs-devel@m.gmane.org; Wed, 27 Aug 2008 22:03:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYWr8-0002oO-7t for emacs-devel@gnu.org; Wed, 27 Aug 2008 22:03:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYWr6-0002nx-Dh for emacs-devel@gnu.org; Wed, 27 Aug 2008 22:03:25 -0400 Original-Received: from [199.232.76.173] (port=55620 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYWr6-0002nu-8R for emacs-devel@gnu.org; Wed, 27 Aug 2008 22:03:24 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:23558 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYWr5-0001O5-KV for emacs-devel@gnu.org; Wed, 27 Aug 2008 22:03:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsIEAHCktUhFxI/k/2dsb2JhbACBZLgMgWiBBw X-IronPort-AV: E=Sophos;i="4.32,283,1217822400"; d="scan'208";a="26063002" Original-Received: from 69-196-143-228.dsl.teksavvy.com (HELO pastel.home) ([69.196.143.228]) by ironport2-out.teksavvy.com with ESMTP; 27 Aug 2008 22:03:22 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 259E47F01; Wed, 27 Aug 2008 22:03:22 -0400 (EDT) In-Reply-To: <86y72igorf.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 27 Aug 2008 15:57:08 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:103064 Archived-At: >>> `change-log-goto-source', so I run an extra `find-file' after SM> Never use `find-file' from Elisp, please. Use pop-to-buffer (together SM> with find-file-noselect if necessary) instead, > Hmm, why does `change-log-find-file' use it? Is it OK because it's a > wrapper around it? That's where I saw the usage, sorry about it. > I've changed it to use `pop-to-buffer' but now it doesn't keep the > original ChangeLog window visible after the first time you run > `next-error'. IOW, you see the ChangeLog the first time you run the > command, but after that it gets buried under the newly found file. > Sorry if this is not helpful, I haven't worked much with window > configurations and arrangements in ELisp. If someone more knowledgeable > wants to take a look, please do. Try to make sure your code behaves like compilation-next-error-function. E.g. it may want to use display-buffer rather than pop-to-buffer. Once you've figured out the trick that makes it work right, please improve the docstring of next-error-function so it explains clearly where/if the buffer should be displayed. Stefan