From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el bug report Date: Wed, 30 Dec 2009 13:32:45 -0500 Message-ID: References: <5065e2900912272219y3734fc9fsdaee41167ef99ad7@mail.gmail.com> <87aax361bd.fsf@red-bean.com> <87my13lf3v.fsf@tux.homenetwork> <72EB214F963A4550B9F1B0EBBCFB48F4@us.oracle.com> <87eimehkg1.fsf@red-bean.com> <87y6kkd1lu.fsf@tux.homenetwork> <87r5qccq7l.fsf@tux.homenetwork> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1262197990 28120 80.91.229.12 (30 Dec 2009 18:33:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Dec 2009 18:33:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 30 19:33:03 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NQ3Lz-0006WW-Ak for ged-emacs-devel@m.gmane.org; Wed, 30 Dec 2009 19:33:03 +0100 Original-Received: from localhost ([127.0.0.1]:57289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQ3Lz-0003TY-MD for ged-emacs-devel@m.gmane.org; Wed, 30 Dec 2009 13:33:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQ3Lu-0003TI-BE for emacs-devel@gnu.org; Wed, 30 Dec 2009 13:32:58 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQ3Lp-0003SW-7y for emacs-devel@gnu.org; Wed, 30 Dec 2009 13:32:57 -0500 Original-Received: from [199.232.76.173] (port=38422 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQ3Lp-0003ST-1D for emacs-devel@gnu.org; Wed, 30 Dec 2009 13:32:53 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:55764) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NQ3Lo-0002Cl-Mu for emacs-devel@gnu.org; Wed, 30 Dec 2009 13:32:52 -0500 Original-Received: from alfajor.home (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id nBUIWlF0002583; Wed, 30 Dec 2009 13:32:49 -0500 Original-Received: by alfajor.home (Postfix, from userid 20848) id E035C64452; Wed, 30 Dec 2009 13:32:45 -0500 (EST) In-Reply-To: <87r5qccq7l.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Wed, 30 Dec 2009 18:43:42 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3438=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119066 Archived-At: >>>> Better would be to place the text property at BOL so there's no need for >>>> any forward-char business. >>> Yes, but remember you have to set properties on the bookmark name >>> without "*"(annotation), ">"(mark), "D"(mark for deletion). >>> That occur on third char and not before. >> Ah, that makes sense. >> So maybe hardcoding 2 is not such a bad idea, but the important thing >> is then that the same "hardcoding" be used both where the property is used >> and where it's set. > Yes, it's why start was set to (point + 2) in *-bmenu-list in my original > patch.(It is like that in bookmark-extensions.el). Yes, that's what I figured in the mean time. So we should probably revert to the "+2" (tho it also has its downside). But please use a defconst to hold the "2". Stefan