From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Redundant (harmful) duplication of run-hooks in define-globalized-minor-mode [patch-2] Date: Thu, 31 Jan 2013 09:38:31 -0500 Message-ID: References: <20130113192854.GA4853@acm.acm> <20130114163003.GC3274@acm.acm> <20130115140855.GA3430@acm.acm> <20130117175159.GA3114@acm.acm> <20130131110404.GA3459@acm.acm> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359643123 29242 80.91.229.3 (31 Jan 2013 14:38:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Jan 2013 14:38:43 +0000 (UTC) Cc: Leo Liu , Chong Yidong , =?iso-8859-1?Q?Jo?= =?iso-8859-1?Q?=E3o_T=E1vora?= , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 31 15:39:02 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U0vI5-0001W6-Gg for ged-emacs-devel@m.gmane.org; Thu, 31 Jan 2013 15:39:01 +0100 Original-Received: from localhost ([::1]:57430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0vHn-00089L-GF for ged-emacs-devel@m.gmane.org; Thu, 31 Jan 2013 09:38:43 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0vHl-000895-6L for emacs-devel@gnu.org; Thu, 31 Jan 2013 09:38:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U0vHe-0000r7-6X for emacs-devel@gnu.org; Thu, 31 Jan 2013 09:38:40 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:60546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0vHe-0000qx-2b; Thu, 31 Jan 2013 09:38:34 -0500 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r0VEcVaJ016669; Thu, 31 Jan 2013 09:38:31 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 882A6B4182; Thu, 31 Jan 2013 09:38:31 -0500 (EST) In-Reply-To: <20130131110404.GA3459@acm.acm> (Alan Mackenzie's message of "Thu, 31 Jan 2013 11:04:04 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4478=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4478> : streams <898105> : uri <1332924> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156735 Archived-At: > + (MODE-cancel-disable > + (intern (concat global-mode-name "-cancel-disable"))) > + (MODE-disable-in-buffer > + (intern (concat global-mode-name "-disable-in-buffer"))) If you defvar-local the MODE-disable-in-buffer, then you shouldn't need MODE-cancel-disable since kill-all-local-variables will have reset MODE-disable-in-buffer to nil already. Stefan