unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] master 6a77459 1/2: New gud replacement package: realgud (a front end interface to
       [not found] ` <E1YMyAp-0003wG-NT@vcs.savannah.gnu.org>
@ 2015-02-15 22:33   ` Stefan Monnier
  2015-02-15 23:47     ` Rocky Bernstein
  0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2015-02-15 22:33 UTC (permalink / raw)
  To: emacs-devel; +Cc: rocky

>     Using .gitmodules in this way is a bit of an experiment. Currently these
>     four projects are separate github repositories.

Don't use submodules: the scripts which build the GNU ELPA packages from
the elpa.git repository don't know what to do with them.

As explained in elpa/README, you can either add your packages as
subdirectories in the main branch (typically using something like "git
subtree" or "git merge -s subtree") or add them as *branches* (called
externals/<pkg>).  They also need to be mentioned in the
elpa/externals-list file (for externals/<pkg> it's indispensible, for
subtrees it's just good practice).


        Stefan


> ---
>  .gitmodules            |   12 ++++++++++++
>  packages/load-relative |    1 +
>  packages/loc-changes   |    1 +
>  packages/realgud       |    1 +
>  packages/test-simple   |    1 +
>  5 files changed, 16 insertions(+), 0 deletions(-)

> diff --git a/.gitmodules b/.gitmodules
> new file mode 100644
> index 0000000..6d90d7e
> --- /dev/null
> +++ b/.gitmodules
> @@ -0,0 +1,12 @@
> +[submodule "packages/test-simple"]
> +	path = packages/test-simple
> +	url = https://github.com/rocky/emacs-test-simple.git
> +[submodule "packages/load-relative"]
> +	path = packages/load-relative
> +	url = https://github.com/rocky/emacs-load-relative.git
> +[submodule "packages/loc-changes"]
> +	path = packages/loc-changes
> +	url = https://github.com/rocky/emacs-loc-changes.git
> +[submodule "packages/realgud"]
> +	path = packages/realgud
> +	url = https://github.com/rocky/emacs-dbgr.git
> diff --git a/packages/load-relative b/packages/load-relative
> new file mode 160000
> index 0000000..15ffaa9
> --- /dev/null
> +++ b/packages/load-relative
> @@ -0,0 +1 @@
> +Subproject commit 15ffaa9ebf1b7bbfcc307d1716eec135253b3b8d
> diff --git a/packages/loc-changes b/packages/loc-changes
> new file mode 160000
> index 0000000..8447baf
> --- /dev/null
> +++ b/packages/loc-changes
> @@ -0,0 +1 @@
> +Subproject commit 8447baff7cb4839ef8d1d747a14e5da85d0cee5b
> diff --git a/packages/realgud b/packages/realgud
> new file mode 160000
> index 0000000..d811316
> --- /dev/null
> +++ b/packages/realgud
> @@ -0,0 +1 @@
> +Subproject commit d811316e6a0f4eeee8a1347f504c196c86baa2cb
> diff --git a/packages/test-simple b/packages/test-simple
> new file mode 160000
> index 0000000..75eea25
> --- /dev/null
> +++ b/packages/test-simple
> @@ -0,0 +1 @@
> +Subproject commit 75eea25bae04d8e5e3e835a2770f02f0ff4602c4



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [elpa] master 6a77459 1/2: New gud replacement package: realgud (a front end interface to
  2015-02-15 22:33   ` [elpa] master 6a77459 1/2: New gud replacement package: realgud (a front end interface to Stefan Monnier
@ 2015-02-15 23:47     ` Rocky Bernstein
  2015-02-15 23:48       ` Rocky Bernstein
  2015-02-16  2:08       ` Stefan Monnier
  0 siblings, 2 replies; 7+ messages in thread
From: Rocky Bernstein @ 2015-02-15 23:47 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 3131 bytes --]

On Sun, Feb 15, 2015 at 5:33 PM, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> >     Using .gitmodules in this way is a bit of an experiment. Currently
> these
> >     four projects are separate github repositories.
>
> Don't use submodules: the scripts which build the GNU ELPA packages from
> the elpa.git repository don't know what to do with them.


> As explained in elpa/README, you can either add your packages as
> subdirectories in the main branch (typically using something like "git
> subtree" or "git merge -s subtree") or add them as *branches* (called
> externals/<pkg>).  They also need to be mentioned in the
> elpa/externals-list file (for externals/<pkg> it's indispensible, for
> subtrees it's just good practice).
>
>
>         Stefan
>

Ok. Thanks for the information. The previous changes have been essentially
reverted. I've added one of the four packages, test-simple, in what I hope
is an acceptable way: as a subtree.

Please double check that test-simple has been added properly. When that is
done properly,  I'll do the others (load-relative, loc-changes, and
realgud) in the corresponding fashion.

I make mistakes. That's why I work on debuggers.


>
> > ---
> >  .gitmodules            |   12 ++++++++++++
> >  packages/load-relative |    1 +
> >  packages/loc-changes   |    1 +
> >  packages/realgud       |    1 +
> >  packages/test-simple   |    1 +
> >  5 files changed, 16 insertions(+), 0 deletions(-)
>
> > diff --git a/.gitmodules b/.gitmodules
> > new file mode 100644
> > index 0000000..6d90d7e
> > --- /dev/null
> > +++ b/.gitmodules
> > @@ -0,0 +1,12 @@
> > +[submodule "packages/test-simple"]
> > +     path = packages/test-simple
> > +     url = https://github.com/rocky/emacs-test-simple.git
> > +[submodule "packages/load-relative"]
> > +     path = packages/load-relative
> > +     url = https://github.com/rocky/emacs-load-relative.git
> > +[submodule "packages/loc-changes"]
> > +     path = packages/loc-changes
> > +     url = https://github.com/rocky/emacs-loc-changes.git
> > +[submodule "packages/realgud"]
> > +     path = packages/realgud
> > +     url = https://github.com/rocky/emacs-dbgr.git
> > diff --git a/packages/load-relative b/packages/load-relative
> > new file mode 160000
> > index 0000000..15ffaa9
> > --- /dev/null
> > +++ b/packages/load-relative
> > @@ -0,0 +1 @@
> > +Subproject commit 15ffaa9ebf1b7bbfcc307d1716eec135253b3b8d
> > diff --git a/packages/loc-changes b/packages/loc-changes
> > new file mode 160000
> > index 0000000..8447baf
> > --- /dev/null
> > +++ b/packages/loc-changes
> > @@ -0,0 +1 @@
> > +Subproject commit 8447baff7cb4839ef8d1d747a14e5da85d0cee5b
> > diff --git a/packages/realgud b/packages/realgud
> > new file mode 160000
> > index 0000000..d811316
> > --- /dev/null
> > +++ b/packages/realgud
> > @@ -0,0 +1 @@
> > +Subproject commit d811316e6a0f4eeee8a1347f504c196c86baa2cb
> > diff --git a/packages/test-simple b/packages/test-simple
> > new file mode 160000
> > index 0000000..75eea25
> > --- /dev/null
> > +++ b/packages/test-simple
> > @@ -0,0 +1 @@
> > +Subproject commit 75eea25bae04d8e5e3e835a2770f02f0ff4602c4
>

[-- Attachment #2: Type: text/html, Size: 4776 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [elpa] master 6a77459 1/2: New gud replacement package: realgud (a front end interface to
  2015-02-15 23:47     ` Rocky Bernstein
@ 2015-02-15 23:48       ` Rocky Bernstein
  2015-02-16  2:05         ` Stefan Monnier
  2015-02-16  2:08       ` Stefan Monnier
  1 sibling, 1 reply; 7+ messages in thread
From: Rocky Bernstein @ 2015-02-15 23:48 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 3408 bytes --]

One other thing. After making a change to externals-list, how does one
check that it works properly?

On Sun, Feb 15, 2015 at 6:47 PM, Rocky Bernstein <rocky@gnu.org> wrote:

> On Sun, Feb 15, 2015 at 5:33 PM, Stefan Monnier <monnier@iro.umontreal.ca>
> wrote:
>
>> >     Using .gitmodules in this way is a bit of an experiment. Currently
>> these
>> >     four projects are separate github repositories.
>>
>> Don't use submodules: the scripts which build the GNU ELPA packages from
>> the elpa.git repository don't know what to do with them.
>
>
>> As explained in elpa/README, you can either add your packages as
>> subdirectories in the main branch (typically using something like "git
>> subtree" or "git merge -s subtree") or add them as *branches* (called
>> externals/<pkg>).  They also need to be mentioned in the
>> elpa/externals-list file (for externals/<pkg> it's indispensible, for
>> subtrees it's just good practice).
>>
>>
>>         Stefan
>>
>
> Ok. Thanks for the information. The previous changes have been essentially
> reverted. I've added one of the four packages, test-simple, in what I hope
> is an acceptable way: as a subtree.
>
> Please double check that test-simple has been added properly. When that is
> done properly,  I'll do the others (load-relative, loc-changes, and
> realgud) in the corresponding fashion.
>
> I make mistakes. That's why I work on debuggers.
>
>
>>
>> > ---
>> >  .gitmodules            |   12 ++++++++++++
>> >  packages/load-relative |    1 +
>> >  packages/loc-changes   |    1 +
>> >  packages/realgud       |    1 +
>> >  packages/test-simple   |    1 +
>> >  5 files changed, 16 insertions(+), 0 deletions(-)
>>
>> > diff --git a/.gitmodules b/.gitmodules
>> > new file mode 100644
>> > index 0000000..6d90d7e
>> > --- /dev/null
>> > +++ b/.gitmodules
>> > @@ -0,0 +1,12 @@
>> > +[submodule "packages/test-simple"]
>> > +     path = packages/test-simple
>> > +     url = https://github.com/rocky/emacs-test-simple.git
>> > +[submodule "packages/load-relative"]
>> > +     path = packages/load-relative
>> > +     url = https://github.com/rocky/emacs-load-relative.git
>> > +[submodule "packages/loc-changes"]
>> > +     path = packages/loc-changes
>> > +     url = https://github.com/rocky/emacs-loc-changes.git
>> > +[submodule "packages/realgud"]
>> > +     path = packages/realgud
>> > +     url = https://github.com/rocky/emacs-dbgr.git
>> > diff --git a/packages/load-relative b/packages/load-relative
>> > new file mode 160000
>> > index 0000000..15ffaa9
>> > --- /dev/null
>> > +++ b/packages/load-relative
>> > @@ -0,0 +1 @@
>> > +Subproject commit 15ffaa9ebf1b7bbfcc307d1716eec135253b3b8d
>> > diff --git a/packages/loc-changes b/packages/loc-changes
>> > new file mode 160000
>> > index 0000000..8447baf
>> > --- /dev/null
>> > +++ b/packages/loc-changes
>> > @@ -0,0 +1 @@
>> > +Subproject commit 8447baff7cb4839ef8d1d747a14e5da85d0cee5b
>> > diff --git a/packages/realgud b/packages/realgud
>> > new file mode 160000
>> > index 0000000..d811316
>> > --- /dev/null
>> > +++ b/packages/realgud
>> > @@ -0,0 +1 @@
>> > +Subproject commit d811316e6a0f4eeee8a1347f504c196c86baa2cb
>> > diff --git a/packages/test-simple b/packages/test-simple
>> > new file mode 160000
>> > index 0000000..75eea25
>> > --- /dev/null
>> > +++ b/packages/test-simple
>> > @@ -0,0 +1 @@
>> > +Subproject commit 75eea25bae04d8e5e3e835a2770f02f0ff4602c4
>>
>
>

[-- Attachment #2: Type: text/html, Size: 5296 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [elpa] master 6a77459 1/2: New gud replacement package: realgud (a front end interface to
  2015-02-15 23:48       ` Rocky Bernstein
@ 2015-02-16  2:05         ` Stefan Monnier
  0 siblings, 0 replies; 7+ messages in thread
From: Stefan Monnier @ 2015-02-16  2:05 UTC (permalink / raw)
  To: Rocky Bernstein; +Cc: emacs-devel

> One other thing. After making a change to externals-list, how does one
> check that it works properly?

As mentioned for "subtree", the info in externals-list is just used as
documentation (basically, it's useful to humans).

Otherwise, "make externals" can used, which will use externals-list to
setup the packages in the "externals/<foo>" branches as
submodule-like subdirectories.



        Stefan


> On Sun, Feb 15, 2015 at 6:47 PM, Rocky Bernstein <rocky@gnu.org> wrote:

>> On Sun, Feb 15, 2015 at 5:33 PM, Stefan Monnier <monnier@iro.umontreal.ca>
>> wrote:
>> 
>>> >     Using .gitmodules in this way is a bit of an experiment. Currently
>>> these
>>> >     four projects are separate github repositories.
>>> 
>>> Don't use submodules: the scripts which build the GNU ELPA packages from
>>> the elpa.git repository don't know what to do with them.
>> 
>> 
>>> As explained in elpa/README, you can either add your packages as
>>> subdirectories in the main branch (typically using something like "git
>>> subtree" or "git merge -s subtree") or add them as *branches* (called
>>> externals/<pkg>).  They also need to be mentioned in the
>>> elpa/externals-list file (for externals/<pkg> it's indispensible, for
>>> subtrees it's just good practice).
>>> 
>>> 
>>> Stefan
>>> 
>> 
>> Ok. Thanks for the information. The previous changes have been essentially
>> reverted. I've added one of the four packages, test-simple, in what I hope
>> is an acceptable way: as a subtree.
>> 
>> Please double check that test-simple has been added properly. When that is
>> done properly,  I'll do the others (load-relative, loc-changes, and
>> realgud) in the corresponding fashion.
>> 
>> I make mistakes. That's why I work on debuggers.
>> 
>> 
>>> 
>>> > ---
>>> >  .gitmodules            |   12 ++++++++++++
>>> >  packages/load-relative |    1 +
>>> >  packages/loc-changes   |    1 +
>>> >  packages/realgud       |    1 +
>>> >  packages/test-simple   |    1 +
>>> >  5 files changed, 16 insertions(+), 0 deletions(-)
>>> 
>>> > diff --git a/.gitmodules b/.gitmodules
>>> > new file mode 100644
>>> > index 0000000..6d90d7e
>>> > --- /dev/null
>>> > +++ b/.gitmodules
>>> > @@ -0,0 +1,12 @@
>>> > +[submodule "packages/test-simple"]
>>> > +     path = packages/test-simple
>>> > +     url = https://github.com/rocky/emacs-test-simple.git
>>> > +[submodule "packages/load-relative"]
>>> > +     path = packages/load-relative
>>> > +     url = https://github.com/rocky/emacs-load-relative.git
>>> > +[submodule "packages/loc-changes"]
>>> > +     path = packages/loc-changes
>>> > +     url = https://github.com/rocky/emacs-loc-changes.git
>>> > +[submodule "packages/realgud"]
>>> > +     path = packages/realgud
>>> > +     url = https://github.com/rocky/emacs-dbgr.git
>>> > diff --git a/packages/load-relative b/packages/load-relative
>>> > new file mode 160000
>>> > index 0000000..15ffaa9
>>> > --- /dev/null
>>> > +++ b/packages/load-relative
>>> > @@ -0,0 +1 @@
>>> > +Subproject commit 15ffaa9ebf1b7bbfcc307d1716eec135253b3b8d
>>> > diff --git a/packages/loc-changes b/packages/loc-changes
>>> > new file mode 160000
>>> > index 0000000..8447baf
>>> > --- /dev/null
>>> > +++ b/packages/loc-changes
>>> > @@ -0,0 +1 @@
>>> > +Subproject commit 8447baff7cb4839ef8d1d747a14e5da85d0cee5b
>>> > diff --git a/packages/realgud b/packages/realgud
>>> > new file mode 160000
>>> > index 0000000..d811316
>>> > --- /dev/null
>>> > +++ b/packages/realgud
>>> > @@ -0,0 +1 @@
>>> > +Subproject commit d811316e6a0f4eeee8a1347f504c196c86baa2cb
>>> > diff --git a/packages/test-simple b/packages/test-simple
>>> > new file mode 160000
>>> > index 0000000..75eea25
>>> > --- /dev/null
>>> > +++ b/packages/test-simple
>>> > @@ -0,0 +1 @@
>>> > +Subproject commit 75eea25bae04d8e5e3e835a2770f02f0ff4602c4
>>> 
>> 
>> 



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [elpa] master 6a77459 1/2: New gud replacement package: realgud (a front end interface to
  2015-02-15 23:47     ` Rocky Bernstein
  2015-02-15 23:48       ` Rocky Bernstein
@ 2015-02-16  2:08       ` Stefan Monnier
  2015-02-16  2:35         ` Stefan Monnier
  1 sibling, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2015-02-16  2:08 UTC (permalink / raw)
  To: Rocky Bernstein; +Cc: emacs-devel

> Ok. Thanks for the information. The previous changes have been essentially
> reverted. I've added one of the four packages, test-simple, in what I hope
> is an acceptable way: as a subtree.

It looks OK from here except for:

   % make check_copyrights
   [...]
   +./test-simple/example/gcd.el
   +./test-simple/example/test-gcd.el
   +./test-simple/test-simple.el
   +./test-simple/test-simple.el:;; Copyright (C) 2010, 2012-2013, 2014 Rocky Bernstein
   +./test-simple/test/test-basic.el
   +./test-simple/test/test-fns.el
   +./test-simple/test/test-no-clear.el
   [...]

which means that the Copyright line of test-simple/test-simple.el still
has your name instead of the FSF's name on it, and that the other *.el
files there are missing the usual copright&license blurb.


        Stefan



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [elpa] master 6a77459 1/2: New gud replacement package: realgud (a front end interface to
  2015-02-16  2:08       ` Stefan Monnier
@ 2015-02-16  2:35         ` Stefan Monnier
  2015-02-16  4:11           ` Rocky Bernstein
  0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2015-02-16  2:35 UTC (permalink / raw)
  To: Rocky Bernstein; +Cc: emacs-devel

>> Ok. Thanks for the information. The previous changes have been essentially
>> reverted. I've added one of the four packages, test-simple, in what I hope
>> is an acceptable way: as a subtree.

> It looks OK from here except for:

Oh, one more thing: the "Author:" header says "Rocky Bernstein" but it
should contain an email address, as in "Rocky Bernstein <rocky@gnu.org>".


        Stefan



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [elpa] master 6a77459 1/2: New gud replacement package: realgud (a front end interface to
  2015-02-16  2:35         ` Stefan Monnier
@ 2015-02-16  4:11           ` Rocky Bernstein
  0 siblings, 0 replies; 7+ messages in thread
From: Rocky Bernstein @ 2015-02-16  4:11 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

On Sun, Feb 15, 2015 at 9:35 PM, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> >> Ok. Thanks for the information. The previous changes have been
> essentially
> >> reverted. I've added one of the four packages, test-simple, in what I
> hope
> >> is an acceptable way: as a subtree.
>
> > It looks OK from here except for:
>
> Oh, one more thing: the "Author:" header says "Rocky Bernstein" but it
> should contain an email address, as in "Rocky Bernstein <rocky@gnu.org>".
>

Ok. with commit 785e186ee6f4a2890e86fdf4e42d8082196e58d5 both the
copyright, boilerplate verbiage and author info issues should be fixed.

If not or there's more, let me know.

[-- Attachment #2: Type: text/html, Size: 1222 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-02-16  4:11 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20150215121943.15106.28763@vcs.savannah.gnu.org>
     [not found] ` <E1YMyAp-0003wG-NT@vcs.savannah.gnu.org>
2015-02-15 22:33   ` [elpa] master 6a77459 1/2: New gud replacement package: realgud (a front end interface to Stefan Monnier
2015-02-15 23:47     ` Rocky Bernstein
2015-02-15 23:48       ` Rocky Bernstein
2015-02-16  2:05         ` Stefan Monnier
2015-02-16  2:08       ` Stefan Monnier
2015-02-16  2:35         ` Stefan Monnier
2015-02-16  4:11           ` Rocky Bernstein

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).