Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes.

Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes.

[Stefan Monnier]

> -                   (advice-remove 'context-coloring-colorize advice)
> +                   (advice-remove #'context-coloring-colorize advice)

Actually, the first argument of `advice-remove' has to be a *symbol*
(bound to a function value) rather than a function, so I think it's
better to write 

                   (advice-remove 'context-coloring-colorize advice)
rather than
                   (advice-remove #'context-coloring-colorize advice)

IOW, I think #' only makes sense at those places where one could also
use a (lambda ...).  It's largely philosophical, admittedly.


        Stefan

Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes.

[Jackson Hamilton]

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]

I figured I could generate more spelling error related compiler errors if I
added the hash. By that motivation, I'd prefer to add them in as many
places as possible.

On Sat, Jun 13, 2015 at 7:59 PM, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> > -                   (advice-remove 'context-coloring-colorize advice)
> > +                   (advice-remove #'context-coloring-colorize advice)
>
> Actually, the first argument of `advice-remove' has to be a *symbol*
> (bound to a function value) rather than a function, so I think it's
> better to write
>
>                    (advice-remove 'context-coloring-colorize advice)
> rather than
>                    (advice-remove #'context-coloring-colorize advice)
>
> IOW, I think #' only makes sense at those places where one could also
> use a (lambda ...).  It's largely philosophical, admittedly.
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 1373 bytes --]

Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes.

[Kaushal]

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

Does that apply to advice-add too?

I use something like

(advice-add #'kill-word :after (lambda (arg) (modi/space-as-i-mean)))


On Thu, Jun 18, 2015 at 5:00 AM Jackson Hamilton <
jackson@jacksonrayhamilton.com> wrote:

> I figured I could generate more spelling error related compiler errors if
> I added the hash. By that motivation, I'd prefer to add them in as many
> places as possible.
>
> On Sat, Jun 13, 2015 at 7:59 PM, Stefan Monnier <monnier@iro.umontreal.ca>
> wrote:
>
>> > -                   (advice-remove 'context-coloring-colorize advice)
>> > +                   (advice-remove #'context-coloring-colorize advice)
>>
>> Actually, the first argument of `advice-remove' has to be a *symbol*
>> (bound to a function value) rather than a function, so I think it's
>> better to write
>>
>>                    (advice-remove 'context-coloring-colorize advice)
>> rather than
>>                    (advice-remove #'context-coloring-colorize advice)
>>
>> IOW, I think #' only makes sense at those places where one could also
>> use a (lambda ...).  It's largely philosophical, admittedly.
>>
>>
>>         Stefan
>>
>
>

[-- Attachment #2: Type: text/html, Size: 1908 bytes --]

Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes.

[Stefan Monnier]

> Does that apply to advice-add too?

Yes.  And to symbol-function, fset, defalias, fboundp,
indirect-function, ...


        Stefan