From: Stefan Monnier <monnier@iro.umontreal.ca>
To: David Kastrup <dak@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Deal gracefully with up-events (Bug#19746)
Date: Mon, 10 Aug 2015 17:58:41 -0400 [thread overview]
Message-ID: <jwvk2t2iz6q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <1439215156-26672-2-git-send-email-dak@gnu.org> (David Kastrup's message of "Mon, 10 Aug 2015 15:59:16 +0200")
> * keyboard.c (apply_modifiers_uncached, parse_solitary_modifier)
> (parse_modifiers_uncached): React gracefully to "up-" modifiers:
> those may easily be injected by user-level Lisp code.
> (read_key_sequence): Discard unbound up-events like unbound
> down-events: they are even more likely only relevant for special
> purposes.
Looks good.
> While Emacs will not produce up-events on its own currently (those are
> converted to drag or click events before being converted to
> Lisp-readable structures), the input queue can be made to contain them
> by synthesizing events to `unread-command-events'. Emacs should deal
> consistently with such events.
This probably belongs in a comment rather than in the ChangeLog.
Stefan
next prev parent reply other threads:[~2015-08-10 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 13:59 (unknown) David Kastrup
2015-08-10 13:59 ` [PATCH] Deal gracefully with up-events (Bug#19746) David Kastrup
2015-08-10 21:58 ` Stefan Monnier [this message]
2015-08-11 5:01 ` David Kastrup
2015-08-10 14:02 ` (unknown) David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk2t2iz6q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dak@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).