* Re: [Emacs-diffs] master 3a21ea1: Add more abbrev tests [not found] ` <E1axM60-0004fY-Fp@vcs.savannah.gnu.org> @ 2016-05-03 16:54 ` Stefan Monnier 2016-05-03 17:22 ` Lars Ingebrigtsen 0 siblings, 1 reply; 2+ messages in thread From: Stefan Monnier @ 2016-05-03 16:54 UTC (permalink / raw) To: emacs-devel; +Cc: Lee Bochicchio > + (let* ((table (obarray-make))) > + (abbrev-table-put table :abbrev-table-modiff 42) > + (should (abbrev-table-empty-p table)))) AFAIK this is a detail of the implementation, so I'm not sure we want to test it. I'd rather test (should (abbrev-table-empty-p (make-abbrev-table))) -- Stefan ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] master 3a21ea1: Add more abbrev tests 2016-05-03 16:54 ` [Emacs-diffs] master 3a21ea1: Add more abbrev tests Stefan Monnier @ 2016-05-03 17:22 ` Lars Ingebrigtsen 0 siblings, 0 replies; 2+ messages in thread From: Lars Ingebrigtsen @ 2016-05-03 17:22 UTC (permalink / raw) To: Stefan Monnier; +Cc: Lee Bochicchio, emacs-devel Stefan Monnier <monnier@IRO.UMontreal.CA> writes: >> + (let* ((table (obarray-make))) >> + (abbrev-table-put table :abbrev-table-modiff 42) >> + (should (abbrev-table-empty-p table)))) > > AFAIK this is a detail of the implementation, so I'm not sure we want to > test it. > I'd rather test > > (should (abbrev-table-empty-p (make-abbrev-table))) Ok; fixed now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-03 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160502221340.17892.39911@vcs.savannah.gnu.org>
[not found] ` <E1axM60-0004fY-Fp@vcs.savannah.gnu.org>
2016-05-03 16:54 ` [Emacs-diffs] master 3a21ea1: Add more abbrev tests Stefan Monnier
2016-05-03 17:22 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).