From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 f172894: Exit macro definition on undefined keys Date: Sun, 01 Oct 2017 09:20:31 -0400 Message-ID: References: <20170930134840.28326.3545@vcs0.savannah.gnu.org> <20170930134841.1354D20514@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1506864080 32581 195.159.176.226 (1 Oct 2017 13:21:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Oct 2017 13:21:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 01 15:21:15 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyeBH-00085U-KE for ged-emacs-devel@m.gmane.org; Sun, 01 Oct 2017 15:21:15 +0200 Original-Received: from localhost ([::1]:48330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyeBO-0005eD-QY for ged-emacs-devel@m.gmane.org; Sun, 01 Oct 2017 09:21:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyeAk-0005e3-P4 for emacs-devel@gnu.org; Sun, 01 Oct 2017 09:20:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyeAi-000171-5R for emacs-devel@gnu.org; Sun, 01 Oct 2017 09:20:42 -0400 Original-Received: from [195.159.176.226] (port=41815 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyeAh-00015z-Px for emacs-devel@gnu.org; Sun, 01 Oct 2017 09:20:40 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dyeAX-0004CR-64 for emacs-devel@gnu.org; Sun, 01 Oct 2017 15:20:29 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 12 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:zrbkdy6R7IWs6wdgkvF+ezphK3M= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218986 Archived-At: > (if defining-kbd-macro > - (error "%s is undefined" (key-description (this-single-command-keys))) > + (user-error "%s is undefined" (key-description > (this-single-command-keys))) > (message "%s is undefined" (key-description (this-single-command-keys)))) I was thinking of using user-error regardless of defining-kbd-macro. This also means to move the `user-error` call to the end of the function. Stefan