From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: rmailmm Date: Thu, 13 Jun 2019 18:15:31 -0400 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="32286"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 14 00:22:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbY6k-00087B-Do for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 00:22:11 +0200 Original-Received: from localhost ([::1]:46086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbY6e-0001OR-U4 for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 18:22:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41903) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbY6M-0001MS-0r for emacs-devel@gnu.org; Thu, 13 Jun 2019 18:21:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbY0T-0000Xc-1m for emacs-devel@gnu.org; Thu, 13 Jun 2019 18:15:43 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12830) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbY0S-0000WD-RU for emacs-devel@gnu.org; Thu, 13 Jun 2019 18:15:40 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A0282810F9 for ; Thu, 13 Jun 2019 18:15:39 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A967B8030C for ; Thu, 13 Jun 2019 18:15:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1560464138; bh=hbV9nZMt4ITp58JEOn4D3VWsVGJr6V4/3b5SlazMa1M=; h=From:To:Subject:References:Date:In-Reply-To:From; b=F6DUrTFk+dL1XlVVSAyhcqiOcvIL9GWbu6o3Wk4AamdeUku9fcVFyjstCftiFeorn mhpG0c0ucpUCuRXqCScvzUpC6dyjGU7EMquoowcuefUPYrsbUOEAepxuR/EoV8zn6t FVM1lsJvWq0eA1CHYD4jltg8CUIhlS2hsJ/s5SAyNKHdMtpxX9gY71JS54tuAFbYYR QBtmW/soHJCrVRn4HBdxo8cR+zrCwaFbPSCEC7PfK/oExQeXsymOyt9zK7d02vVAgM fl8O9VkwSPtVGKKk5vOmVQ41lCgqSvklHWWK+9XdvIVG8V3hvApBEN4cLZtHvF7eXJ V0EX0Jq2IsFHw== Original-Received: from alfajor (cm-84.215.66.78.getinternet.no [84.215.66.78]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 495B0120AA1 for ; Thu, 13 Jun 2019 18:15:38 -0400 (EDT) In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 13 Jun 2019 14:44:13 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237558 Archived-At: > In rmail-mime-insert-bulk: > mail/rmailmm.el:839:21:Warning: `string-as-unibyte' is an obsolete function > (as of 26.1); use `encode-coding-string'. [...] > I've stared at the code some, but I'm not totally sure what it's doing > here. Yeah, I looked at the history and that didn't enlighten me either (it was introduced in 2e9075d3968a2542d47b7e64a1e457711568373d, i.e. soon after the release of Emacs-23.1 where the internal encoding changed to utf-8 and Rmail changed from babyl to mbox format). > But... wouldn't string-to-unibyte be the right thing here anyway? I'd tend to agree. string-as-unibyte ends up basically encoding with `utf-8-emacs-unix` coding-system which seems like an odd choice here. > I'm not an rmail user, so I can't test this. Neither am I. Stefan