From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: fix for bug#34330 breaks makefile target complete in `compile' prompt
Date: Sun, 15 Sep 2019 08:50:08 -0400 [thread overview]
Message-ID: <jwvk1a9d93c.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8636gxq5wr.fsf@stephe-leake.org> (Stephen Leake's message of "Sun, 15 Sep 2019 02:12:52 -0700")
> It's not clear from this if "applicable" means "there are actual
> completions", but it appears that it should.
No. The idea rather is to decide on the completion-table to use only
based on *where* we are. You can't easily know whether there are
any completions (because it depends on completion-styles).
Maybe we should remove comint-filename-completion from the list of
completion functions and rely on pcomplete-default-completion-function
for that instead?
Or maybe shell-dynamic-complete-functions should not do like
completion-at-point-functions and should run all its functions (without
stopping at the first non-nil answer) and then combine them using
completion-table-in-turn?
Stefan
next prev parent reply other threads:[~2019-09-15 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-15 9:12 fix for bug#34330 breaks makefile target complete in `compile' prompt Stephen Leake
2019-09-15 12:50 ` Stefan Monnier [this message]
2019-09-15 20:07 ` Stephen Leake
2019-09-15 21:05 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk1a9d93c.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).