From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring Date: Thu, 17 Oct 2019 14:31:44 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204359"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eli Zaretskii , Lars Ingebrigtsen , Drew Adams , Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 17 20:32:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLAZ7-000r0Y-Uz for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2019 20:32:02 +0200 Original-Received: from localhost ([::1]:56256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLAZ6-0002xh-Fx for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2019 14:32:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60352) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLAYy-0002xU-F7 for emacs-devel@gnu.org; Thu, 17 Oct 2019 14:31:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLAYw-0008Jy-TZ for emacs-devel@gnu.org; Thu, 17 Oct 2019 14:31:51 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39836) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLAYv-0008In-70; Thu, 17 Oct 2019 14:31:49 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5020C811EE; Thu, 17 Oct 2019 14:31:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B9653806F9; Thu, 17 Oct 2019 14:31:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1571337105; bh=QDBy2z6nNy5XdHkRjs4ecZYUG9Peu+MA5iVi5R4evq4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=khC6XC2QCKE7yGhzsjQqqPDRTXwJYG27s70wm1u2cKkNLwFQCwBV3UU3oZEoOnchA BTXVSFbFB8tCG7QzVH+O2XqisOkuLZN2TA6ua7iRBAuQ4di/rrmaN2T3A2miR4LgUJ JzrFFyqIX2X7hlHr8OI6KCQlQnaLeoiljEc3/7Eeh3oHs/6NyDGCT5ZEpZrHhvMiH7 IbTN/gumpP6DdH18+3p5gnSHkCbOEMAEzqtqtKln2rTJQpGeTIhiZ672Wbtu+v7Wb/ szyuEQp0ocLeBwGTHiaEozySaMhzGSQj2xHYFGMe3OS5sOiob65I4hud2VfwbxyrSl dsUlSUj0HhqNA== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9DE2F120254; Thu, 17 Oct 2019 14:31:45 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Thu, 17 Oct 2019 20:18:15 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241166 Archived-At: > There's a cascading effect. Indeed, that's another reason why consistency is beneficial. > So I think functions that can only return a boolean are not > "overspecified" by saying so. That's because you think they should return t. For those whose think they should return non-nil, it's overspecified (even if they do only ever return t in practice). > FWIW, I don't consider making a function return what its docstring says "a > cosmetic change". I think a single bikeshed subject is sufficient, so I won't take this opportunity to debate the definition of "cosmetic". Stefan