From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188) Date: Sat, 05 Sep 2020 15:41:52 -0400 Message-ID: References: <20200904211737.15548.63989@vcs0.savannah.gnu.org> <20200904211738.DA94720667@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19767"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andrii Kolomoiets Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 05 21:42:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEe5H-00053P-3Q for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Sep 2020 21:42:47 +0200 Original-Received: from localhost ([::1]:40166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEe5G-0000OI-5t for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Sep 2020 15:42:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEe4Y-0008Ij-PH for emacs-devel@gnu.org; Sat, 05 Sep 2020 15:42:02 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEe4X-0005X4-AO for emacs-devel@gnu.org; Sat, 05 Sep 2020 15:42:02 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3640510022C; Sat, 5 Sep 2020 15:42:00 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DAAE110005D; Sat, 5 Sep 2020 15:41:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599334913; bh=TSGDWXRI4kfR5X8uvVAcmjlFTytwtTkcehbMxh4twOk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=V0XPqpIznkZoO4nE9xXNdiftokKUtZ9n9hZQ7iTh08FmVLW2kEEu6zN0gwlU8erMQ haujWHoFiIlfovuGNDXwafjr2EVkjjNBF8fjH7o9z+txvg2Pr+avWHwrx7gypGpNN/ 5fKNMKvs3c5wVkFO0ELmCKTcHXu7lJjinKlC+nPrWfTQ0tpoV4myjJsGe2wSNmeOuG YbBeuBzAPVMzCi8lHT7Ev1bTIgJat4RPKWlqVqlQoEiVM/dvVlslLgKQCL5LNBB4mw UfH/7sdChzUVPw9NgB24zf03g+giVVf7qSsdhnN0YnGznHNXc0+lYhMtR6mN1jE20C xgWSClrAWqwZw== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 83EB7120315; Sat, 5 Sep 2020 15:41:53 -0400 (EDT) In-Reply-To: (Andrii Kolomoiets's message of "Sat, 05 Sep 2020 22:34:00 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/05 14:03:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254550 Archived-At: > - (save-excursion > + (let ((p (point))) > (dolist (node nodes) > - (ewoc--refresh-node pp node dll))))) > + (ewoc--refresh-node pp node dll)) > + (goto-char p)))) Hmm... I think this is an improvement when point is within the refreshed node, but a regression when it's further down in the buffer. Stefan