From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master d067ac5: Remove more compat code from prolog.el Date: Fri, 25 Sep 2020 10:04:43 -0400 Message-ID: References: <20200925093755.19433.41297@vcs0.savannah.gnu.org> <20200925093756.C7849209D4@vcs0.savannah.gnu.org> <87tuvmnez9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16551"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 25 16:05:51 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLoMB-0004CN-Oo for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Sep 2020 16:05:51 +0200 Original-Received: from localhost ([::1]:55824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLoMA-0006JT-Qs for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Sep 2020 10:05:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLoLC-0005F5-SP for emacs-devel@gnu.org; Fri, 25 Sep 2020 10:04:50 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7268) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLoLA-0002dQ-N6 for emacs-devel@gnu.org; Fri, 25 Sep 2020 10:04:50 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 09DC6813A2; Fri, 25 Sep 2020 10:04:46 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 62DE280252; Fri, 25 Sep 2020 10:04:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1601042684; bh=gKbpAL0ecPtIQZAb/Tcal9glJzIOD4edRn3z02G5jik=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=F81VEpn+yjzb3bKWRnq2N06WJr6qLGh+y0E4U4D3CWvY1ZnMIr8HGo1inUAmTde/7 Pj2eiPPGXViDcgFGqXGRw9tVR+DrqdCISDXxGBF4aKVbtofuJWwaLhUkgfhvFaEnmZ s9f17rU4O60u0iwW28Kmw/ZUUXU/1YQf4uZkcZ8XL7vcaNSnJm3SSnGHnzVMbeoUUJ xYBD4QxQv8oUOvTtKMw6IYhauhisNkQSS/vc2aUMMs68UYxPGMJ/CrDM89MfJ4Qjl7 SmIW1V+Ad5rzM9RKYOGONb5+L79ZdbpSqrETRXFoFocrsTMScTwfjS6q9LbEKp4ICl 2W+vGhPDMBB5g== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3D3D2120264; Fri, 25 Sep 2020 10:04:44 -0400 (EDT) In-Reply-To: <87tuvmnez9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 25 Sep 2020 15:49:30 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/25 08:39:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256431 Archived-At: >>> (if (eq prolog-system 'mercury) >>> (list >>> (regexp-opt prolog-directives-i 'words) >>> - 0 'prolog-warning-face))) >>> + 0 prolog-warning-face))) >>> ;; Inferior mode specific patterns [...] > All the other places there used the variable instead of the symbol, > I think? For instance: > > ;; FIXME: Add to compilation-error-regexp-alist instead. > (cond > ((eq prolog-system 'sicstus) > '("[ \t]*[0-9]+[ \t]+[0-9]+[ \t]*\\(Fail\\):" > 1 prolog-warning-face)) > ((eq prolog-system 'swi) > '("[ \t]*\\(Fail\\):[ \t]*([ \t0-9]*)" 1 prolog-warning-face)) Those other places are within a quote. Stefan