From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Thu, 05 Nov 2020 13:50:26 -0500 Message-ID: References: <20201104161200.tyeo2r5jibdahukb.ref@Ergus> <20201104161200.tyeo2r5jibdahukb@Ergus> <234bba7f-fd5c-ed39-8a5e-8a6ce3125bf1@inventati.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21495"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gregory Heytings , Manuel Uberti , emacs-devel@gnu.org To: Jean Louis Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 05 19:53:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kakO7-0005TY-Mb for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 19:53:35 +0100 Original-Received: from localhost ([::1]:60030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kakO6-0005Q9-NR for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 13:53:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kakLB-0003db-Ip for emacs-devel@gnu.org; Thu, 05 Nov 2020 13:50:33 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kakL8-00042G-MP for emacs-devel@gnu.org; Thu, 05 Nov 2020 13:50:32 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3340480853; Thu, 5 Nov 2020 13:50:29 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AEF2080922; Thu, 5 Nov 2020 13:50:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604602227; bh=K9YvGIOwWVJ8ihB+01YhlRZD+UaXFkzob2+/y4Io+zU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GC0BWsr6p3eSAG9wVmT97kq56XmztWCF6ZA4Db/C6Tt0gMNQdm+LitN+a+LT6QKuo SiLLkD3hmNae4gwUd4Gpx34kzEUrA6v5P+Jx3dkuzdVCJXpf1BdgEJ1c1sRXktps4y bq3XG6aurmD9gW0FWgxrSgjfnW5VbHjtabJNA6IfTz3Qb8S7GBbff4l1OX6PKOrps0 LYnjZW2CIqy6A6SmyenVPDAcYbSTdK9qe5iZTRdaEaT1YhQasu0jiZhVm7RQf3gEmF EOUTcIKru0Gke8b5vd+ZVt3pxUzfHltUJn6WKlup1Om9+yIapMkxQXJdOzKdjcXnMe JydAjQhXI173A== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7B5D01201DA; Thu, 5 Nov 2020 13:50:27 -0500 (EST) In-Reply-To: (Jean Louis's message of "Thu, 5 Nov 2020 20:32:32 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 09:21:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258750 Archived-At: > I don't think that embark is what I mean. Here is short screen how > actions are implemented in Helm with TAB: > > https://gnu.support/images/tmp/2020-11-05-20:26:22.ogv > > I can then choose what to do on the selection instead of the default > action. In Ivy actions are also there but with M-o > > If function icomplete-completing-read is not there, I still need to > use external packages. It is more useful if it is there. > > How can I checkout that branch? FWIW, such actions would be a great addition to the generic completion. If done well, it could help unify a bit more Ivy, Helm, Icomplete, and the default completion. Currently in Icomplete there is a very limited and ad-hoc support for actions in the form of the "kill" action when selecting buffers. I think we should try and generalize that. If someone with experience with Ivy or Helm actions would like to tackle that, that'd be great. And if they feel like they don't know enough about the minibuffer.el code for that, don't be afraid: I'd be happy to help. Stefan