From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Calling internal-default-process-sentinel from another sentinel? Date: Wed, 18 Nov 2020 09:44:18 -0500 Message-ID: References: <87sg966bh5.fsf@gmail.com> <87pn4a688z.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19696"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 18 15:45:33 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfOiC-0004zO-EP for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 15:45:32 +0100 Original-Received: from localhost ([::1]:51224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfOiB-0006QK-Gh for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 09:45:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfOh6-0005Z0-CZ for emacs-devel@gnu.org; Wed, 18 Nov 2020 09:44:24 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfOh4-0004RA-56 for emacs-devel@gnu.org; Wed, 18 Nov 2020 09:44:23 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 661D144031A; Wed, 18 Nov 2020 09:44:20 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CEC3C440293; Wed, 18 Nov 2020 09:44:18 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1605710658; bh=ySNZa9OsTuGBP0IbDDA9Akyfa3V7ESh5BA0HXMOI+a0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oSzeCq6wLMbzcfvdUk6SB69Mcg5GJSnBTVVWGFCBQQ/c5CtQv9TRslJfnbxMNpcQQ tnx6wk3S6LoN+WvSc3PTCbSFYLmKTc70iPkZRk1vgVZss1aBLK4KuGRQ+jO7hiNl7j F+sUYqYQuCWgNd9G/Gq0oBkMWrtWeHHU0QeI/3lrkcU1Q5zs3UHiRBPkC1LqanJSHC 2jUPmAgZoiPjHE05bDosH81CGtUgLRLIbTjdL+dFupDIisZEZb42YDy6DOl5C70ubB VgIFg8PUKoQt6Mgsb48JoTVNFaz75zHIgRg8bEvabxPiRqh/+oPRLPJ3oBHqyVYolR sJsm5hjZNgm3Q== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9EA34120371; Wed, 18 Nov 2020 09:44:18 -0500 (EST) In-Reply-To: <87pn4a688z.fsf@gmail.com> (=?utf-8?B?IsWgdMSbcMOhbiBOxJtt?= =?utf-8?B?ZWMiJ3M=?= message of "Wed, 18 Nov 2020 15:37:48 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/18 09:04:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259348 Archived-At: >>> Such a use case doesn't seem uncommon and simply calling >>> 'internal-default-process-sentinel' from a custom sentinel would seem a >>> good solution, but the "internal-" prefix or the fact that such usage is >>> completely absent from Emacs core and very rare even in 3rd party >>> code[1] don't inspire confidence. >> >> `add-function` is your friend. >> >> (add-function :around (process-sentinel proc) >> (lambda (orig-fun proc state) >> (if (one particular case) >> (do the thing) >> (funcall orig-fun proc state)))) > > Thanks, I've seen similar examples in the code base, but always advising > an Elisp sentinel, not 'internal-default-process-sentinel', which is a C > function, and IIUC also would/might be called from C (e.g. from > status_notify ?). Or is the actual default sentinel some kind of a > wrapper? This is not advising 'internal-default-process-sentinel'. It just replaces the sentinel by a new function which often delegates to the previous function, whichever that previous function was and without affecting that previous function's definition. > And even for Elisp sentinels, I figured I'd rather avoid advice, as even > when using a self-removing piece of advice, it still applies to all > (even unrelated) calls of the same sentinel function occurring until the > removal. Or am I missing something? You're confused: this is not an "advice". Stefan