unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 8fd97b1 1/2: Fix warning generated by indian.el + quail.el
Date: Wed, 24 Feb 2021 16:19:03 -0500	[thread overview]
Message-ID: <jwvk0qxjhdy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k0qx5gda.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 24 Feb 2021 22:02:25 +0100")

>> Would the patch below fix this problem more directly?
>
> [...]
>
>> -	    (while (re-search-forward "^[ \t]*(quail-define-package" nil t)
>> +	    (while (re-search-forward "^[ \t]*(quail-define-package[ \t\n]*\"" nil t)
>
> I'm not sure?  This all ends up as a (register-input-method ...) call,
> which is a function, from which I inferred that literal strings aren't
> necessarily required here (i.e., that you can quail-define-package with
> a variable name as the first element).  

But IIRC those that we want to extract are specifically those that
are already "fully computed".  In theory we could miss some things like

    (let ((name "foo"))
      (quail-define-package name ...))

but that seems very unlikely.


        Stefan




  reply	other threads:[~2021-02-24 21:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210224193216.21758.72611@vcs0.savannah.gnu.org>
     [not found] ` <20210224193217.F016720B28@vcs0.savannah.gnu.org>
2021-02-24 20:57   ` master 8fd97b1 1/2: Fix warning generated by indian.el + quail.el Stefan Monnier
2021-02-24 21:02     ` Lars Ingebrigtsen
2021-02-24 21:19       ` Stefan Monnier [this message]
2021-02-24 22:20         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk0qxjhdy.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).