From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/pyim 9f017ac 18/36: New file: pyim-entered.el Date: Thu, 22 Apr 2021 23:19:49 -0400 Message-ID: References: <20210423025712.4844.13627@vcs0.savannah.gnu.org> <20210423025718.7AA4220D12@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32662"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Feng Shu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 23 05:20:58 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZmNF-0008Pk-Tl for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Apr 2021 05:20:57 +0200 Original-Received: from localhost ([::1]:59258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZmNF-00058B-0T for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Apr 2021 23:20:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZmMF-0004bz-3c for emacs-devel@gnu.org; Thu, 22 Apr 2021 23:19:55 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZmMD-0001n5-KR for emacs-devel@gnu.org; Thu, 22 Apr 2021 23:19:54 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EF7C410050F; Thu, 22 Apr 2021 23:19:52 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 374EA100311; Thu, 22 Apr 2021 23:19:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619147991; bh=3H57AYPC+2rpD6WOlHV99LfZpaj3iAk8ORcc2pznghc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PqX2/eFfyE/K6DRH8HmSdTx9K/zcBLm8StITK3SXiLxvXWWfnHghWE6kVp1BWa8Gn pMF5kEqR+PuCWSvWkZ55rd5wDrsR4co9WqwXZ9qfWgKWAxecbY3Ou+jAqQuV7mdST4 YhkO5H2HV/CYW1MbqhmN480i2W7HzJhpiaRVPM7pqrT+DrSeu0yRALFzRX1TpqBr7n 95BAd+nW/HhQjPVsmQZLXI3vlXifWBmaCFQvMLj0zUgA5UuWHjv/VkUJPeVUpmJvdH Z929H5e9EVsCFACQIafgsZtjM9yEoH7hZy1YJy15PGzn5lAqCmIIvI4j8coePVlzlX jez14AWSpfV8g== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0475C120323; Thu, 22 Apr 2021 23:19:50 -0400 (EDT) In-Reply-To: <20210423025718.7AA4220D12@vcs0.savannah.gnu.org> (ELPA Syncer's message of "Thu, 22 Apr 2021 22:57:18 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268300 Archived-At: > + (pyim-with-entered-buffer > + (cond > + ((equal 1 (point)) > + (buffer-string)) > + ((eq type 'point-before) > + (buffer-substring-no-properties 1 (point))) I recommend you use (point-min) rather than hardcoding 1. It's a good practice in general, and as a bonus it leads to marginally better bytecode. Stefan