From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Integrate my package into Emacs Date: Tue, 24 May 2022 18:59:05 -0400 Message-ID: References: <3a9397d6-7d11-f9f7-bcf6-03ccfa83e67f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8335"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mariano Montone Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 25 01:13:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntdiv-0001yj-Mj for ged-emacs-devel@m.gmane-mx.org; Wed, 25 May 2022 01:13:57 +0200 Original-Received: from localhost ([::1]:40270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntdiu-000070-Q1 for ged-emacs-devel@m.gmane-mx.org; Tue, 24 May 2022 19:13:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntdUe-0006Uj-Lp for emacs-devel@gnu.org; Tue, 24 May 2022 18:59:12 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntdUc-0005Om-67 for emacs-devel@gnu.org; Tue, 24 May 2022 18:59:12 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9C2FB80723; Tue, 24 May 2022 18:59:08 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AFE908007C; Tue, 24 May 2022 18:59:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1653433146; bh=jTTvfN/OKRr1ax9ZIRz2/bK1MccBN2h7xmMUy8g6KDU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=a91bO3J9vzWE1SAjesMjNIn1XTpL9WYMccnqT3e2I2v2QdmSJJMBKKhg6tfnVUTeY lTUaa0k9yMpXu7Pgdl6Av+j2xRb/PjzyJToIIfnxQLr2x7x/Awvjj4Gb0/wgz5UPvs IRrzhxeaymjerSHZxgJ9fzmTEYuElFbkpkPSS0RfMHcma0nk0W6tHt2I+kXSwJY7Hn oqwxdqj3kxxrt3hAndfs2U4fISP6Vur3NFnxZLwQ3hm1WrprR8CoKlAQBRVYjO3H2P zQ3BfWWsgoG7pqFEf4dBblgH8i6ApwWMSTRO1ekdx7TehScafV+Ow4RdmL458mzNiY vs6RCKyEenIxg== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 77FDF1208EC; Tue, 24 May 2022 18:59:06 -0400 (EDT) In-Reply-To: <3a9397d6-7d11-f9f7-bcf6-03ccfa83e67f@gmail.com> (Mariano Montone's message of "Tue, 24 May 2022 16:22:37 -0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290219 Archived-At: Mariano Montone [2022-05-24 16:22:37] wrote: > I've signed the papers and applied your changes. Yay! > What would be the next step? Can you have a look again at my package let > me know? I just pushed it to `elpa.git`. It won't appear on GNU ELPA yet, tho because your copyright line still has your name. You'll have to change it to the FSF (and after that (or at the same time) change the `Version:` to make a "new" release from that). See patch below which includes the copyright change along with various FIXME comments (meant to be read rather than applied. If you have any questions/answers about those FIXMEs, feel free to send them right here). Stefan diff --git a/README.md b/README.md index 06a6d142be..743dfcd604 100644 --- a/README.md +++ b/README.md @@ -6,6 +6,11 @@ Inspector tool for Emacs Lisp objects. Similar to inspectors available for Smalltalk and Common Lisp, but for Emacs Lisp. + DEMO VIDEO: https://drive.google.com/file/d/1808JlDM0q-aW4woZQBscatxp6omIR2j8/view ![emacs-inspector.png](emacs-inspector.png "Emacs Inspector") diff --git a/inspector.el b/inspector.el index f32416198d..d011bc6ce0 100644 --- a/inspector.el +++ b/inspector.el @@ -1,6 +1,6 @@ ;;; inspector.el --- Tool for inspection of Emacs Lisp objects. -*- lexical-binding: t -*- -;; Copyright (C) 2021 Mariano Montone +;; Copyright (C) 2021-2022 Free Software Foundation, Inc. ;; Author: Mariano Montone ;; URL: https://github.com/mmontone/emacs-inspector @@ -616,6 +616,8 @@ When PRESERVE-HISTORY is T, inspector history is not cleared." ;;;###autoload (defun inspect-last-sexp () + ;; FIXME: According to the code, this doesn't inspect the "sexp before point" + ;; but the value returned by the evaluation of that sexp. "Evaluate and inspect sexp before point." (interactive) (let ((result (eval (eval-sexp-add-defvars (elisp--preceding-sexp)) lexical-binding))) @@ -623,6 +625,9 @@ When PRESERVE-HISTORY is T, inspector history is not cleared." ;;-- Inspection from Emacs debugger +;; FIXME: Please use the "inspect-" namespace instead of stepping onto +;; the debugger's namespace, e.g. `inspect-debugger-locals'. + ;;;###autoload (defun debugger-inspect-locals () "Inspect local variables of the frame at point in debugger backtrace." @@ -683,13 +688,9 @@ When PRESERVE-HISTORY is T, inspector history is not cleared." :vert-only t) map)) -(add-hook 'inspector-mode-hook - (lambda () - (setq-local tool-bar-map inspector-tool-bar-map))) - -;; Better define and use a major mode?: -(define-derived-mode inspector-mode fundamental-mode - "Inspector mode") +(define-derived-mode inspector-mode fundamental-mode "Inspector" + "Major mode for the Emacs Lisp Inspector." + (setq-local tool-bar-map inspector-tool-bar-map)) (provide 'inspector)