From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Docstring hack Date: Sun, 31 Jul 2022 17:32:27 -0400 Message-ID: References: <83bkt6687a.fsf@gnu.org> <871qu2lo29.fsf@yahoo.com> <837d3u63ez.fsf@gnu.org> <834jyy61w6.fsf@gnu.org> <831qu25z5x.fsf@gnu.org> <87mtcqhvot.fsf@yahoo.com> <83sfmh4x0o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30197"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , Po Lu , emacs-devel To: Lynn Winebarger Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 31 23:33:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIGYy-0007d1-Qt for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 23:33:29 +0200 Original-Received: from localhost ([::1]:35242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIGYx-0003n2-Bw for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 17:33:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIGYB-00037C-EB for emacs-devel@gnu.org; Sun, 31 Jul 2022 17:32:39 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIGY8-0008LZ-Pw; Sun, 31 Jul 2022 17:32:38 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3895580722; Sun, 31 Jul 2022 17:32:34 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C9B4980065; Sun, 31 Jul 2022 17:32:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1659303152; bh=YUMN+/LJ6vopp9tsUNnAQqO8anzsgjjX4TbknXZP98Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dNOlqxub9tlr11Pk+ksUVqpibuz4ekwcWmNrv6SG7a9D66vDNPbbVd7//dXWJzKCb BaY6JMLWrAeHsz1GuXa0O/GbsyLiOGEDdv0+ZFLWKazBaHnbCw/98KvRCmxaEzPLq6 tCEx+AS2UMHkvuAUIYoZtTlV1hpKYV8M1Lhc1oberzIkTg3giq+YEl2wWtreBFBv84 nnv49C6nAPDs6kPqVM48hcxOzVIOrQyd0lHsIicqyGWh5xR6L6/D1KI+HzAV6A9pnz f+BXugz8FYc7RCT00YW8jnZTXwSbB8J8Syl41JZWGOqcZtpwiG04V3IweHMo3LicY+ 9ovCtX/HFhbSg== Original-Received: from milanesa (dyn.144-85-174-155.dsl.vtx.ch [144.85.174.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CA7C41202BB; Sun, 31 Jul 2022 17:32:31 -0400 (EDT) In-Reply-To: (Lynn Winebarger's message of "Sun, 31 Jul 2022 08:43:09 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292926 Archived-At: > mode, then that is overkill. I don't understand why the docstrings are > even being extracted for the byte compiled files at all, since they would > be lazy loaded anyway. Then you could remove the files from lisp.mk from > the dependencies of DOC in the Makefile and just leave loaddefs and the > docstrings from C source files. That's indeed what we in Emacs-29. > This is the conundrum of trying to do anything significant in site-load > without Makefile support. If you're bootstrapping, then none of those > files are compiled. So I put in a check to only load after the bootstrap > during the dump. But nothing is byte compiled at this point other than the > files in loadup. Trying to do the byte compile from within site-load after > the bootstrap but during the dump requires pre loading the source of all > dependencies, because require and autoload hit the panic button in dump > mode. Loading `site-load.el` in the first dump is a bad idea because files haven't been compiled yet. Loading `site-load.el` in the second dump is a bad idea because: - as currently written, the site-loaded files aren't compiled, so it's too early to dump them. - if you change the build to byte-compile them before the second dump, you'll be byte-compiling them with the bootstrap-emacs which might work but will lead to a slower compilation. So, I suggest something like: mv lisp/site-load.el lisp/my-site-load.el make rm src/emacs mv lisp/my-site-load.el lisp/site-load.el mv lisp/my-site-load.elc lisp/site-load.elc make So the first 2 dumps are "normal" without any site-loaded files, and that's followed by a 3rd dump, where all the ELisp files are already byte-compiled. Stefan