unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Gregory Heytings <gregory@heytings.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	 acm@muc.de,  schwab@linux-m68k.org, emacs-devel@gnu.org
Subject: Re: Using Emacs in fbterm.
Date: Tue, 30 Aug 2022 14:26:43 -0400	[thread overview]
Message-ID: <jwvk06pzj3h.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <dacea928889f84f21232@heytings.org> (Gregory Heytings's message of "Tue, 30 Aug 2022 15:37:56 +0000")

>>> +;;; fbterm.el  -*- lexical-binding:t -*-
>>> +(require 'term/xterm)
>> This lacks the usual license blurb, of course
> Short files in lisp/term/ do not have that license blurb, I thought it was
> on purpose?

Hmm..... interesting.  I don't know what should be done in this respect.
But the important thing is to explain/document the why of the code so
that 10 years from now someone will know how to maintain it.

>>> + (ignore-errors (when gpm-mouse-mode (require 't-mouse) (gpm-mouse-enable))))
>> Hmm... this seems to point to a problem/shortcoming in `t-mouse.el` which
>> should arguably do that automatically, no?
> I confess I blindly copied that line from linux.el, thinking it was
> probably useful for something.

It should probably be removed from there as well.  If it causes
a regression that should be fixed in `t-mouse.el` or at the very least
come with a clear description of the problem it fixes.

> After some testing it doesn't seem to make a difference, so I'll just
> remove it.

Great, thanks,


        Stefan




  reply	other threads:[~2022-08-30 18:26 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 16:41 Using Emacs in fbterm Alan Mackenzie
2022-08-29 17:33 ` Eli Zaretskii
2022-08-29 18:44   ` Alan Mackenzie
2022-08-29 18:53     ` Eli Zaretskii
2022-08-29 18:54     ` Gregory Heytings
2022-08-29 18:59       ` Eli Zaretskii
2022-08-29 19:29         ` Gregory Heytings
2022-08-29 19:42           ` Eli Zaretskii
2022-08-29 19:45             ` Gregory Heytings
2022-08-29 19:55               ` Gregory Heytings
2022-08-29 19:34       ` Andreas Schwab
2022-08-29 19:43         ` Gregory Heytings
2022-08-29 19:52           ` Andreas Schwab
2022-08-29 20:27             ` Gregory Heytings
2022-08-29 20:35               ` Alan Mackenzie
2022-08-29 20:52                 ` Gregory Heytings
2022-08-29 22:28                   ` Gregory Heytings
2022-08-30 11:32                     ` Eli Zaretskii
2022-08-30 12:04                       ` Gregory Heytings
2022-08-30 12:10                         ` Eli Zaretskii
2022-08-30 21:10                           ` Gregory Heytings
2022-08-30 13:16                         ` Stefan Monnier
2022-08-30 15:37                           ` Gregory Heytings
2022-08-30 18:26                             ` Stefan Monnier [this message]
2022-08-30 21:20                               ` Gregory Heytings
2022-08-30 21:56                                 ` Stefan Monnier
2022-08-30 22:07                                   ` Gregory Heytings
2022-09-04  2:59                                     ` Stefan Monnier
2022-08-29 18:50 ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk06pzj3h.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gregory@heytings.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).