From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Sun, 30 Oct 2022 10:36:44 -0400 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <878rle1i0k.fsf@posteo.net> <87ilkelc10.fsf@posteo.net> <878rl6syg8.fsf@posteo.net> <87zgdjqcu0.fsf@posteo.net> <87zgdivc3f.fsf@posteo.net> <874jvqv2u3.fsf@posteo.net> <875yg6qtbl.fsf@posteo.net> <87ilk33lqk.fsf@posteo.net> <87mt9epqlk.fsf@posteo.net> <87ilk1bgvd.fsf@posteo.net> <87edupbdp0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21572"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Richard Stallman , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 30 15:37:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1op9RP-0005LY-Be for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Oct 2022 15:37:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op9Ql-0000gz-2x; Sun, 30 Oct 2022 10:36:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op9Qi-0000eO-Rr for emacs-devel@gnu.org; Sun, 30 Oct 2022 10:36:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op9Qh-0000gW-0x; Sun, 30 Oct 2022 10:36:52 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9E06B80762; Sun, 30 Oct 2022 10:36:48 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EB86880436; Sun, 30 Oct 2022 10:36:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667140607; bh=SnbvSLWYveTnNQhJvWz1Iv5JulJ9s4Ifjoa1XTo5mzI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dsPcpZJelyerssi0vD+S5F0hshf9WlQjCrNGqeyAcxs4gNXYSGLp2xQU+i3kpluhR n/qX36Ej50IAkQrmibSIf+pzfvaQbIIyTAFdnrXrDOQofTqbaGKzl/pif7Ey5C7sqs fiU3XYXgsilytpQM9Mzu4jFSqKlng5a+PMR8QZHR1rufsPvI8V0brWlLJQkK4FpyqE 1TKZ9TeM/SbHl7X0wTrBgnWdO3hD2K8OCpCtWxnUyxcF2TZtR/p148A8sKBzasStvN +MLIMKHhd0x2ci+tM53cZ1u+ReDyGd6jrJllxfkumZ/i2ZqgPaOMSxRys//Qyxm5sh ZZ0RNTVtrEwJg== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 930EB1206C1; Sun, 30 Oct 2022 10:36:46 -0400 (EDT) In-Reply-To: <87edupbdp0.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 30 Oct 2022 14:15:07 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298818 Archived-At: Philip Kaludercic [2022-10-30 14:15:07] wrote: > Stefan Monnier writes: >>> I guess so. Here is a possible patch that should behave close enough to >>> elpa-admin.el using "blame" >> >> Why do you use `blame` rather than `log` like `elpa-admin.el`? > > I tried to use log like in elpa-admin.el, but the issue was I had to > either > > 1. Define the generic interface to search for a line using a regular > expression that is not an Elisp regular expression, and could > conceivably differ between different VCS that might also implement > 'last-change'. > > 2. Deal with the issue that the Version header might move between > revisions, meaning that a line range wouldn't do a good job at > capturing the right commit. FWIW, I suspect that your `git blame` will give the same answer as the corresponding `git log` (it will probably end up using the same code under the hood), but I don't understand what you mean above. I think `git log` would accept the exact same `-L` as you use for `git blame` and will deal with "the issue that the Version header might move" in the exact same way. >> Hmm... the code I see in your patch uses `vc-region-history` (which is >> only supported for Git and Hg, currently, and is fairly difficult to >> support in a generic way) rather than `vc-annotate`. >> Am I missing something? > > Uh, that is my mistake. I started writing that code yesterday (I > believe?) and simply forgot what I had used. I'll try to translate that > into vc-annotate before pushing anything. [ Just to be clear, I wasn't implying a preference between `vc-annotate` and `vc-region-history`. As fallback, they both seem fine to me. ] > Checking out a specific revision is currently only done right after > cloning, so this is always a reset. The issue here is that I am trying > to stay generic and was using 'vc-retrieve-tag' (but perhaps > 'vc-checkout' would be better), so this is an issue that might have to > be tackled in vc-git.el... I find this part of VC beyond repair: AFAICT the notion of "tag/snapshot/..." has been defined "on the fly" with a narrow view of what was needed for one particular situation at a particular time. It's probably worth "throwing it out" (well, keeping it on life support) and introducing a whole new set of operations based on a design that tries to accommodate all the various related notions out there. Stefan