From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Code navigation for sh-mode with Tree-sitter Date: Tue, 06 Dec 2022 11:48:32 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14274"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Mackenzie , emacs-devel@gnu.org To: =?windows-1252?Q?Jo=E3o?= Paulo Labegalini de Carvalho Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 06 17:49:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2b8c-0003U9-7T for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Dec 2022 17:49:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2b7n-0001za-ET; Tue, 06 Dec 2022 11:48:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2b7b-0001yR-Gn for emacs-devel@gnu.org; Tue, 06 Dec 2022 11:48:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2b7Z-0000yb-R3 for emacs-devel@gnu.org; Tue, 06 Dec 2022 11:48:43 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3483D8004C; Tue, 6 Dec 2022 11:48:40 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4D1A080263; Tue, 6 Dec 2022 11:48:34 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670345314; bh=LvhrrISSNbKuwOWuQlh9VZch5fdcibpLcnONvaWpTBg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hzJq1glnB+uOXSfghwfwAKDIGPKqX9SuHSw/OZCNF5p7nxhiGpQKJK0T8RWJpCEBc 2MMKPWNfoCrBXTMFqkkAFkRCrKm9V4Zis9rJRMPW8IgKO5n8m0Wgo7TmfcrdC89ta6 3ptptWqrBkXTDg7k10MaOAbEeA5LOUSIgG1g/SNH/VU4wPXoek5YB+3RaoONWXNMZH tUuqUAKK6FA643dkDDjV7LG8W/RUMLWfcMzzwr5D6djzJZfyPrx6edDEhVUyZwiMtC LqWZDLFWTOP55h3BtNSKj/SIPuv05GJFp1Y91z5ekRBVInEQI/LRxr23KMDqlMXc8u D5LDmQS84N3Ug== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 37F66122557; Tue, 6 Dec 2022 11:48:34 -0500 (EST) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o?= Paulo Labegalini de Carvalho"'s message of "Tue, 6 Dec 2022 08:51:07 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300973 Archived-At: >> Calling beginning-of-defun-function followed by end-of-defun-function >> (and comparing the resulting position to the start position) should be >> sufficient to let you know whether or not you're inside the function >> whose definition starts most closely before point. >> > > Hmm. In sh-mode `beginning-of-defun-function' is nil and in the example > below, calling `end-of-defun-function' with M-: (funcall > end-of-defun-function) brings point to fi and not the end of the function. Many major modes do not implement those two functions in a fully reliable way, indeed. `bash-ts-mode` should be able to implement them reliably, OTOH. > In the example above, C-M-a and C-M-e do the right thing. However, in the > presence of nested functions, C-M-a and C-M-e only navigate over top-level > functions. For example: Yes, it's a common limitation when the major mode is unable to do proper parsing of the code. Stefan