From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 558b59d81b 2/2: Add color fontification in css-ts-mode (bug#60405) Date: Thu, 29 Dec 2022 15:40:07 -0500 Message-ID: References: <167234360508.10049.9573467005634789859@vcs2.savannah.gnu.org> <20221229195325.91363C004B0@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30989"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Yuan Fu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 29 21:41:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAziA-0007vC-Ik for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Dec 2022 21:41:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAzhS-0001Fz-FE; Thu, 29 Dec 2022 15:40:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAzhJ-0001F8-W0 for emacs-devel@gnu.org; Thu, 29 Dec 2022 15:40:18 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAzhI-0001py-29 for emacs-devel@gnu.org; Thu, 29 Dec 2022 15:40:17 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 88BE880485; Thu, 29 Dec 2022 15:40:12 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E45C2805D4; Thu, 29 Dec 2022 15:40:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1672346410; bh=BCq82hIEGDPkD0D6Rdcuo7vdN7x4ZVSlbAnrDKV0hqI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GEK6j3uMt51AcUSzhVZkIqGtqandSLPvt7euVB082xOZEW3BOHK30T+YRw+93Mp4S 3RdB/LXG1cUVVJUVWTuRreWPhaa+SmkFxtajC73RL2Vxuw7Nh6xNlcRHsxr0m385hi vmJC4saKMIe39gVIHacWrTxQ+Y8glI0SVNF8haJYY4MqWI+h6lLxb+AbqTGerG+MIZ riEtm5IM2t3PBBAAeaqc4kHYEKFzzckFHlKDrKmDtdLVxrebzWukD62oBqY7MlMGh0 uWvn3iRItVSPeYl5MyLUveBwBzofH46D+DIxp8bfPGmFk9Xffg2E+2KisitjEFdvlB QGgwdpkMrxULQ== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 86DF9120B01; Thu, 29 Dec 2022 15:40:10 -0500 (EST) In-Reply-To: <20221229195325.91363C004B0@vcs2.savannah.gnu.org> (Yuan Fu's message of "Thu, 29 Dec 2022 14:53:25 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302068 Archived-At: > Add color fontification in css-ts-mode (bug#60405) > > * lisp/textmodes/css-mode.el (css-ts-mode): Add color fontification > and syntax-propertize-function. > --- > lisp/textmodes/css-mode.el | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el > index 19f5fa303f..e8d9725948 100644 > --- a/lisp/textmodes/css-mode.el > +++ b/lisp/textmodes/css-mode.el > @@ -1804,11 +1804,15 @@ can also be used to fill comments. > :syntax-table css-mode-syntax-table > (when (treesit-ready-p 'css) > ;; Borrowed from `css-mode'. > + (setq-local syntax-propertize-function > + css-syntax-propertize-function) It's not clear to me why we need to set `syntax-propertize-function` here, so I think it deserves a comment. Stefan