From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/haskell-mode d16c68ccdf 2/2: Merge pull request #1829 from DataKinds/master Date: Wed, 25 Oct 2023 07:31:01 -0400 Message-ID: References: <169823166043.2094.16911105176687452779@vcs2.savannah.gnu.org> <20231025110101.AAD84C09BE6@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19025"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Steve Purcell Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 25 13:32:03 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvc7G-0004fw-3S for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Oct 2023 13:32:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvc6W-0001ur-5b; Wed, 25 Oct 2023 07:31:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvc6U-0001ui-Kh for emacs-devel@gnu.org; Wed, 25 Oct 2023 07:31:14 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvc6S-0000P0-I6 for emacs-devel@gnu.org; Wed, 25 Oct 2023 07:31:14 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 67D06440C9A; Wed, 25 Oct 2023 07:31:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1698233468; bh=groAsz0BYnhS713P3MbywPJo6jW/PxwQvjaWJ6e3GX4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ok6LIZSYmEFQLVh41F0MNmbbGmpbgI8oNbN5NW79wie+FpQL1z/aCtpn1mV/0W13y Anfh79JvzaHyv1e3gfblpVYgD/vvjOyh46NNsGZ/Ys5mY2zmtuNtclDdjTCMnJiJUM EhZAofgWu3bZZW3LRzh8ebyyYIHSEtn6BkFkXkQsrAZ1dJimu71bXfDN5OAsrLS7e/ E0SRSPZNYVBJERDkIgL0ZPNTc3CRXMOLhf+KycdCiRv4vQEgIXAVJcCja4rrnF0EpP W/nUJdDfDGhzod/5k6o57SFiIFhsN4jKK+Qid0JZZ+1sogsaPt63UIZvoyNN91kjAE yJwza9swmJTNA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E5AD4440C8B; Wed, 25 Oct 2023 07:31:08 -0400 (EDT) Original-Received: from pastel (unknown [45.72.216.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A936C120321; Wed, 25 Oct 2023 07:31:08 -0400 (EDT) In-Reply-To: <20231025110101.AAD84C09BE6@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Wed, 25 Oct 2023 07:01:00 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311833 Archived-At: > +(defun haskell-indentation-tex-outside-code-p () > + "Non-NIL if we are in tex literate mode, but outside of code." > + (and (haskell-indentation-tex-p) > + (if (save-excursion > + (re-search-forward "\\(\\\\end\{code\}\\|\\\\begin\{code\}\\)" nil t)) > + (cond ((equal "\\end{code}" (match-string-no-properties 0)) nil) > + ((equal "\\begin{code}" (match-string-no-properties 0)) t)) > + (save-excursion (re-search-backward "\\\\end\{code\}" nil t))))) [ The \ in front of the braces do nothing and the \\(..\\) subgroup is unused. ] We don't need to allocate strings here, we can just do: (if (save-excursion (re-search-forward "\\\\end{code}\\|\\\\begin{code}\\(\\)" nil t)) (match-end 1) (save-excursion (re-search-backward "\\\\end{code}" nil t))))) And personally, I'd recommend: (not (and (save-excursion (re-search-backward "\\\\end{code}\\|\\\\begin{code}\\(\\)" nil t)) (match-end 1))) -- Stefan