From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions Date: Mon, 04 Mar 2024 10:55:13 -0500 Message-ID: References: <170950733941.30552.13228431602613197760@vcs2.savannah.gnu.org> <20240303230900.51D39C12C5F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25108"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 04 16:56:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhAfW-0006HS-6T for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Mar 2024 16:55:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhAew-0008Uf-9q; Mon, 04 Mar 2024 10:55:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhAeu-0008U5-Lr for emacs-devel@gnu.org; Mon, 04 Mar 2024 10:55:20 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhAes-0003h3-1p; Mon, 04 Mar 2024 10:55:20 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 11AB680C88; Mon, 4 Mar 2024 10:55:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1709567714; bh=FsE75uJsw7Vkqbs8E+wh9xzv1FEQZLAkD3rV8Pb7H/M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Slog7ZE3TIUitqP/hIRh92f2hJ7hCTtnEmToCOgOUMhqj40tOnBUF9KvDLlNDTcsR 89Z7qvNG4pZMz4NGnuJrvSAoUvL/bxvszP+Sl79xtduYYs2RsykiT0oEqMVeFDY/nC L5qDDXXrKCBN4kSp+ZYo9ihK59hitCvf20na2RigSgMUtes1wL6xm4kge2evXDHGMM 99cvAkEHdCK2LUrX1WwllnXZGsfRGQbUui1L+Pw5G0M3B5eRHtt2oqZNAr0lBlj6HY 1arT7vsQ+g3NENhnn85Fipp+47O6JyayjsurwrCNTE258uGZRZPFJ5AqKffVsHSHwZ FgHceivmmuKEw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 37C4080135; Mon, 4 Mar 2024 10:55:14 -0500 (EST) Original-Received: from pastel (unknown [104.247.233.29]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 15EB8120679; Mon, 4 Mar 2024 10:55:14 -0500 (EST) In-Reply-To: (Andrea Corallo's message of "Mon, 04 Mar 2024 04:46:29 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316799 Archived-At: >> I'm not sure I understand. Is some code relying on the "order" of the >> supertypes? Are these the regression you are mentioning? >> Must say I'm surprised supertypes can have an "order" in first place. Hmm... a lot of what I've been talking about in this thread is about the order of parents in `cl--typeof-types`, so yes, the order is important. It determines the priority between methods. > Also, this commit makes etc/syncdoc-type-hierarchy.el not functional and > our doc out of sync (it removes the comment asking to run > etc/syncdoc-type-hierarchy.el when changing 'cl--type-hierarchy' as well > =F0=9F=99=81). Duh, thanks for point it out, I'll update the code accordingly. Stefan