From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Turning on/off tree-sitter modes Date: Tue, 03 Dec 2024 09:55:55 -0500 Message-ID: References: <9cd17f8b-f88c-49f6-9024-0b6d297e18ac@gutov.dev> <867c8xsmri.fsf@gnu.org> <566ac897-ea5e-4141-bcb3-306d43c9118a@gutov.dev> <865xohrvfa.fsf@gnu.org> <86wmgwnyle.fsf@gnu.org> <178dfc7f-bc2d-4e3b-8417-a616ccc0eef3@gutov.dev> <86v7wgnxlz.fsf@gnu.org> <01d83ec8-c02b-4806-8764-38dc89a89125@gutov.dev> <86ttbzojho.fsf@gnu.org> <930f5c8e-1481-43a5-8f1d-2c13a98df74f@gutov.dev> <86r072krq5.fsf@gnu.org> <27a62624-387c-4233-b995-170270e26efd@gutov.dev> <86iks245q0.fsf@gnu.org> <86bjxt2avf.fsf@gnu.org> <86wmgg26rt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13237"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dmitry@gutov.dev, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 03 15:56:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIUKY-0003ET-4b for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Dec 2024 15:56:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIUJw-0004we-Ob; Tue, 03 Dec 2024 09:56:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIUJv-0004vX-87 for emacs-devel@gnu.org; Tue, 03 Dec 2024 09:56:11 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIUJq-0002ln-Tp; Tue, 03 Dec 2024 09:56:10 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B49364427F6; Tue, 3 Dec 2024 09:56:03 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1733237762; bh=mwR2q1YI7pr+E1PrqIk4Tiqg8Uc20vN72AkLGATv8gk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=O2pvCCQtED2TdPHcXsA9qPXuj+ew84qO+V0C5RlPNNrcAx/7QvEIJHCGZbticv6AA Wm8Yv0wIMDBovaIkGd5TUEKWZb3aACGCzsalRRui+K3/HTwcZ/Xz7M/RvhV4tJ28KS BbWxU2oszQF4CXzr3612/djXaJN12EtP6FLM55BPq3IU2BR2jo3No9UKxeLIQ1Kmk0 KFczgil8pbZnU2t2mjFfW85aGYRDTQ0SFVHgAOI+QkSCEpeyRWlKNhygmW5cTX6CtX 0+yVdrc7tMq0Cpa0Yadpb/I0uM/A+qRQyggCDpCsWpoFw8ZEL36s/XZJ24qigpC7tA SFV3QJSdB5qPg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 88117441133; Tue, 3 Dec 2024 09:56:02 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5CDEC1200F0; Tue, 3 Dec 2024 09:56:02 -0500 (EST) In-Reply-To: <86wmgg26rt.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 Dec 2024 16:14:14 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325991 Archived-At: >> >> Do you have a concrete example? >> > >> > cmake-ts-mode, dockerfile-ts-mode, elixir-ts-mode, lua-ts-mode, to >> > name just a few. Basically any FOO-ts-mode for which we don't have a >> > corresponding FOO-mode. >> >> Let's take the `cmake-ts-mode` as an example, then. >> I consider it currently broken: >> >> emacs -Q foo.cmake >> >> should put you in `cmake-ts-mode` when you have the CMake >> tree-sitter grammar installed, but instead it remains in >> fundamental-mode. >> >> Until this is fixed I don't see any sense in discussing how the users >> can specify whether they prefer `cmake-mode` or `cmake-ts-mode`. > > I think we are mis-communicating. This thread's Subject is "Turning > on/off tree-sitter modes", so I'm asking: what we will tell users to > to do if they want to turn ON cmake-ts-mode? And the answer depends on how we fix the current breakage, but most likely it will be "same as for other modes, except doing nothing works as well"? > I didn't mean to say anything about the imaginary cmake-mode, I meant > to point out that it doesn't exist in Emacs, so our solution to this > cannot be based solely on major-mode-remap-defaults/alist. Why not? One way to fix the current breakage is with a patch like the one below, after which the way to choose which CMake mode to use is the same as for any other mode. Stefan diff --git a/lisp/progmodes/cmake-ts-mode.el b/lisp/progmodes/cmake-ts-mode.el index 597ef69d9b8..bf713fff2ae 100644 --- a/lisp/progmodes/cmake-ts-mode.el +++ b/lisp/progmodes/cmake-ts-mode.el @@ -245,8 +245,22 @@ cmake-ts-mode (derived-mode-add-parents 'cmake-ts-mode '(cmake-mode)) (if (treesit-ready-p 'cmake) - (add-to-list 'auto-mode-alist - '("\\(?:CMakeLists\\.txt\\|\\.cmake\\)\\'" . cmake-ts-mode))) + (add-to-list 'major-mode-remap-defaults '(cmake-mode . cmake-ts-mode))) + +;;;###autoload (add-to-list 'auto-mode-alist +;;;###autoload '("\\(?:CMakeLists\\.txt\\|\\.cmake\\)\\'" +;;;###autoload . cmake-mode)) + +;;;###autoload (add-to-list 'major-mode-remap-defaults +;;;###autoload '(cmake-mode . cmake-ts-mode-maybe)) + +;;;###autoload +(defun cmake-ts-mode-maybe () + "Enable `cmake-ts-mode' if available." + (cond + ((treesit-ready-p 'cmake) (cmake-ts-mode)) + ((fboundp 'cmake-mode) (cmake-mode)) + (t (fundamental-mode)))) (provide 'cmake-ts-mode)