unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Daniel Pettersson <daniel@dpettersson.net>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/dape bd1c30d52e 1/5: Fix out of hexl region error
Date: Wed, 08 Jan 2025 11:12:58 -0500	[thread overview]
Message-ID: <jwvjzb5qoev.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m2plkytojm.fsf@dpettersson.net> (Daniel Pettersson's message of "Tue, 07 Jan 2025 20:24:45 +0100")

> I am not sure if it makes sense to drop hexl support (if not nhexl is
> moved into core) but I am all for adding some custom's for swapping out
> hexl-mode for nhexl-mode if that is what the user wants.

[ I'll let you decide how that should work.  ]

> Currently the dape-read-memory installs:
> - variable for address offset
> - revert-function to convert base64 string into hexl buffer
> - write-contents-functions function for converting back into base64 and
> sending to debug adapter

Sounds like these would also be needed for nhexl, tho probably
with the details being different.

> It would be preferable if nhexl-mode had some built in way of setting
> the offset.

Yes, I'd be happy to change nhexl mode to better support Dape.
Should I expect a patch from you?


        Stefan




      reply	other threads:[~2025-01-08 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <173551666483.747519.2819007587227627326@vcs3.savannah.gnu.org>
     [not found] ` <20241229235745.92F9ADB4A4B@vcs3.savannah.gnu.org>
2024-12-30  4:36   ` [elpa] externals/dape bd1c30d52e 1/5: Fix out of hexl region error Stefan Monnier
2025-01-07 19:24     ` Daniel Pettersson
2025-01-08 16:12       ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvjzb5qoev.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=daniel@dpettersson.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).