From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 'Eli Zaretskii' <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: tabs v spaces in Emacs's source files
Date: Sat, 08 Mar 2008 21:40:25 -0500 [thread overview]
Message-ID: <jwviqzwzklv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <002d01c88172$eabd52b0$0600a8c0@us.oracle.com> (Drew Adams's message of "Sat, 8 Mar 2008 15:19:53 -0800")
>> > When we post patches, we generally create them
>> > using `diff -c -w' AFAIK, which would seem to suggest an
>> > agnostic (or at least a loose) approach to indenting whitespace.
>>
>> Actually, you should drop the -w when you generate patches, because it
>> causes trouble for Patch (unless the -l switch to Patch is used, which
>> is easily forgotten).
> Really? I seem to recall someone mentioning here that -c -w was what was
> preferred.
I generally prefer "-u -w" when it's a patch for review.
And "-u" when it's a request to apply the patch.
Stefan
next prev parent reply other threads:[~2008-03-09 2:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 4:33 tabs v spaces in Emacs's source files Glenn Morris
2008-03-07 4:44 ` Miles Bader
2008-03-07 10:19 ` Andreas Schwab
2008-03-07 11:18 ` Juanma Barranquero
2008-03-07 12:28 ` Pete Forman
2008-03-07 14:56 ` Juanma Barranquero
2008-03-07 15:02 ` Johan Bockgård
2008-03-07 15:10 ` Juanma Barranquero
2008-03-07 17:11 ` Karl Fogel
2008-03-08 0:38 ` Juanma Barranquero
2008-03-08 12:58 ` Eli Zaretskii
2008-03-08 20:52 ` Stefan Monnier
2008-03-08 21:13 ` Bill Wohler
2008-03-08 23:56 ` Miles Bader
2008-03-09 16:39 ` Richard Stallman
2008-03-07 17:21 ` Drew Adams
2008-03-08 13:00 ` Eli Zaretskii
2008-03-08 23:19 ` Drew Adams
2008-03-09 2:40 ` Stefan Monnier [this message]
2008-03-08 17:40 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviqzwzklv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).