Re: Binary network communication appears broken

[Stefan Monnier <monnier@iro.umontreal.ca>]

> I discovered this because it breaks mew:
> (This is with CVS emacs as of yesterday.
> I spent many hours debugging my way to this simple test case.)

> Define this function:

> (defun test-net (coding)
>   (interactive "SUse coding: ")
>   (make-network-process
>    :name "testproc"
>    :host 'local :service 9898 :family 'ipv4
>    :buffer "*testproc*"
>    :coding coding
>    :filter (lambda (proc string)
> 	     (setq *test* string ))
>    :sentinel (lambda (proc string)
> 	       (delete-process proc))))

Thank you very much for your efforts.

Does the patch below help?


        Stefan


--- coding.c.~1.374.~	2008-03-25 11:59:11.000000000 -0400
+++ coding.c	2008-03-27 14:51:31.000000000 -0400
@@ -7030,10 +7030,10 @@
       || (! NILP (CODING_ATTR_POST_READ (attrs))
 	  && NILP (dst_object)))
     {
-      coding->dst_object = code_conversion_save (1, 1);
+      coding->dst_multibyte = !CODING_FOR_UNIBYTE (coding);
+      coding->dst_object = code_conversion_save (1, coding->dst_multibyte);
       coding->dst_pos = BEG;
       coding->dst_pos_byte = BEG_BYTE;
-      coding->dst_multibyte = !CODING_FOR_UNIBYTE (coding);
     }
   else if (BUFFERP (dst_object))
     {