unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* cvs-bury-buffer: use quit-window instead of bury-buffer
@ 2008-04-16 17:20 Sam Steingold
  2008-04-18  0:39 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Sam Steingold @ 2008-04-16 17:20 UTC (permalink / raw)
  To: emacs-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

is it OK to apply this:

- --- pcvs-util.el.~1.37.~	2008-04-07 11:57:04.000000000 -0400
+++ pcvs-util.el	2008-04-16 13:11:10.000965000 -0400
@@ -102,20 +102,7 @@ BUF is assumed to be a temporary buffer
~     (let ((win (if (eq buf (window-buffer (selected-window)))
(selected-window)
~ 		 (get-buffer-window buf t))))
~       (when win
- -	(if (window-dedicated-p win)
- -	    (condition-case ()
- -		(delete-window win)
- -	      (error (iconify-frame (window-frame win))))
- -;;; 	  (if (and mainbuf (get-buffer-window mainbuf))
- -;;; 	      ;; FIXME: if the buffer popped into a pre-existing window,
- -;;; 	      ;; we don't want to delete that window.
- -;;; 	      t ;;(delete-window win)
- -;;; 	      )
- -	  )))
- -    (with-current-buffer buf
- -      (bury-buffer (unless (and (eq buf (window-buffer 
(selected-window)))
- -				(not (window-dedicated-p (selected-window))))
- -		     buf)))
+        (quit-window nil win)))
~     (when mainbuf
~       (let ((mainwin (or (get-buffer-window mainbuf)
~ 			 (get-buffer-window mainbuf 'visible))))
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIBjVrPp1Qsf2qnMcRAvCcAKCpSWXREiGtGujCMygzH2L1tqEBCACfYWp8
A50ame0AmbYr7AjyMQ8DW6w=
=IKeP
-----END PGP SIGNATURE-----





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: cvs-bury-buffer: use quit-window instead of bury-buffer
  2008-04-16 17:20 cvs-bury-buffer: use quit-window instead of bury-buffer Sam Steingold
@ 2008-04-18  0:39 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2008-04-18  0:39 UTC (permalink / raw)
  To: Sam Steingold; +Cc: emacs-devel

> is it OK to apply this:

No.  `quit-window' will delete (dedicated) frames, which means losing
the position&size information, so it should only be done when explicitly
requested by the user, whereas `cvs-bury-buffer' may be called
implicitly as part of other commands.


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-18  0:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-16 17:20 cvs-bury-buffer: use quit-window instead of bury-buffer Sam Steingold
2008-04-18  0:39 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).