From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: C-r and C-s in minibuffer should search completion Date: Tue, 22 Apr 2008 22:28:55 -0400 Message-ID: References: <87y77zlqji.fsf@jurta.org> <873aq2czp4.fsf@jurta.org> <871w5j2ca1.fsf@jurta.org> <87r6d6vjg2.fsf@jurta.org> <87od89sb4y.fsf@jurta.org> <87mynsrg9m.fsf@jurta.org> <87zlrp8zn1.fsf@jurta.org> <873aph5v28.fsf@jurta.org> <873apec0j6.fsf@jurta.org> <87y775hai4.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208917753 17380 80.91.229.12 (23 Apr 2008 02:29:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Apr 2008 02:29:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 23 04:29:48 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JoUk0-0002Ro-83 for ged-emacs-devel@m.gmane.org; Wed, 23 Apr 2008 04:29:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JoUjK-0004Kq-KY for ged-emacs-devel@m.gmane.org; Tue, 22 Apr 2008 22:29:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JoUjF-0004Is-T0 for emacs-devel@gnu.org; Tue, 22 Apr 2008 22:29:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JoUjD-0004Hw-AX for emacs-devel@gnu.org; Tue, 22 Apr 2008 22:29:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JoUjD-0004Ht-5x for emacs-devel@gnu.org; Tue, 22 Apr 2008 22:28:59 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182] helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JoUjC-0004RK-S8 for emacs-devel@gnu.org; Tue, 22 Apr 2008 22:28:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah4CAAY8DkjO+KGddGdsb2JhbACBUpACASqbJw X-IronPort-AV: E=Sophos;i="4.25,696,1199682000"; d="scan'208";a="18902170" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 22 Apr 2008 22:28:55 -0400 Original-Received: from pastel.home ([206.248.161.157]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id DGZ17455; Tue, 22 Apr 2008 22:28:55 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 080B58066; Tue, 22 Apr 2008 22:28:55 -0400 (EDT) In-Reply-To: <87y775hai4.fsf@jurta.org> (Juri Linkov's message of "Tue, 22 Apr 2008 23:59:57 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95821 Archived-At: >>> Ah, I accidentally tested this with a Lisp version of >>> `internal-complete-buffer' that I created earlier. >>> But when I restored the C version of `internal-complete-buffer', >>> it doesn't work with it. >> >>> I don't understand why it works with with the equivalent >>> Lisp version, but not with the C version. The C version >>> returns a full buffer list disregarding the `predicate' arg. >>> This is a working Lisp version for your reference: >> >> That is strange indeed. Could you investigate? > It is very inconvenient to debug higher-order functions when part > of functionality is implemented in C. This is another reason to > move completion functions to Lisp. > Nevertheless, I've found that this was caused by internal-complete-buffer > that really uses a cons pair of (buffer-name . buffer) for the > buffer name argument. I installed a fixed version of > internal-complete-buffer-except. Thanks, Stefan