From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Build failure on M$ (using MSVC): Patch enclosed Date: Thu, 22 May 2008 11:45:04 -0400 Message-ID: References: <85od6yltju.fsf@lola.goethe.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211471259 10499 80.91.229.12 (22 May 2008 15:47:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 May 2008 15:47:39 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 22 17:48:16 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JzD0Z-0004ps-2t for ged-emacs-devel@m.gmane.org; Thu, 22 May 2008 17:47:11 +0200 Original-Received: from localhost ([127.0.0.1]:34235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JzCzo-0004mp-JN for ged-emacs-devel@m.gmane.org; Thu, 22 May 2008 11:46:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JzCzi-0004lz-P7 for emacs-devel@gnu.org; Thu, 22 May 2008 11:46:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JzCzg-0004kU-MO for emacs-devel@gnu.org; Thu, 22 May 2008 11:46:17 -0400 Original-Received: from [199.232.76.173] (port=54105 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JzCzg-0004kF-Br for emacs-devel@gnu.org; Thu, 22 May 2008 11:46:16 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:42808) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JzCzX-0005LT-EY; Thu, 22 May 2008 11:46:07 -0400 Original-Received: from ceviche.home (vpn-132-204-232-121.acd.umontreal.ca [132.204.232.121]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m4MFkNS2021335; Thu, 22 May 2008 11:46:23 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3657870910; Thu, 22 May 2008 11:45:04 -0400 (EDT) In-Reply-To: <85od6yltju.fsf@lola.goethe.zz> (David Kastrup's message of "Thu, 22 May 2008 08:52:21 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3021=0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97532 Archived-At: > On a different tack: why can't vc-find-root be made to use > locate-dominating-file? One less bunch of heuristics to maintain. Yes, this duplication hurts. After all, I wrote locate-dominating-file based on vc-find-root. But currently locate-dominating-file can only be used if the file we're looking for is directoly in the higher directory, not in a subdirectory. E.g. I can look for ".dir-settings.el" or "CVS" but not for "CVS/Entries", as does vc-find-root. Stefan