From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: VC error
Date: Tue, 03 Jun 2008 03:56:28 -0400 [thread overview]
Message-ID: <jwviqwrrlyn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <874p8b8f86.fsf@stupidchicken.com> (Chong Yidong's message of "Mon, 02 Jun 2008 21:44:09 -0400")
> I've been getting (void-variable vc-client-mode) errors whenever I try
> using VC operation with debug-on-error set to non-nil.
> Anyone else seen this?
> One way to reproduce this is simply:
> emacs -Q
> C-x C-f emacs/lisp/vc-dispatcher.el
> M-: (eval-buffer) RET
> Debugger entered--Lisp error: (void-variable vc-client-mode)
> (vc-client-object->extra-menu vc-client-mode)
> (funcall (vc-client-object->extra-menu vc-client-mode))
Hopefully, I've just fixed this,
Stefan
--- vc-dispatcher.el.~1.58.~ 2008-05-27 10:05:20.000000000 -0400
+++ vc-dispatcher.el 2008-06-03 03:55:24.000000000 -0400
@@ -760,7 +760,10 @@
(when (and (symbolp orig-binding) (fboundp orig-binding))
(setq orig-binding (indirect-function orig-binding)))
(let ((ext-binding
- (funcall (vc-client-object->extra-menu vc-client-mode))))
+ ;; This may be executed at load-time for tool-bar-local-item-from-menu
+ ;; but at that time vc-client-mode is not known (or even bound) yet.
+ (when (and (boundp 'vc-client-mode) vc-client-mode)
+ (funcall (vc-client-object->extra-menu vc-client-mode)))))
(if (null ext-binding)
orig-binding
(append orig-binding
next prev parent reply other threads:[~2008-06-03 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 1:44 VC error Chong Yidong
2008-06-03 7:56 ` Stefan Monnier [this message]
2008-06-03 21:18 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviqwrrlyn.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).