Ruby mode added

Ruby mode added

[Chong Yidong]

Richard has okayed adding Ruby-mode to CVS, and I've done so.  I made a
few changes with respect to Phil Hagelberg's version at github:

- Moved definition of ruby-mode to the end of the file to avoid compiler
  warnings.

- Removed the defun-region-command macro.  Is there a better way for
  this file to remain XEmacs-compatible without this hack?

(eval-when-compile
  (defmacro defun-region-command (func args &rest body)
    (let ((intr (car body)))
      (when (featurep 'xemacs)
        (if (stringp intr) (setq intr (cadr body)))
        (and (eq (car intr) 'interactive)
             (setq intr (cdr intr))
             (setcar intr (concat "_" (car intr)))))
      (cons 'defun (cons func (cons args body))))))

- There seemed to be a reference to an unbound variable, `indent-point',
  in ruby-parse-partial.  I assumed this was an attempt to use dynamic
  scope to access the let-bound variable `indent-point' in
  ruby-calculate-indent; therefore I renamed indent-point as
  ruby-indent-point and added a `boundp' check.  Phil, could you check
  if this is the intention of the code?

I have also updated NEWS and the Emacs manual.

Does anyone see any problem?

Re: Ruby mode added

[Dan Nicolaescu]

Chong Yidong <cyd@stupidchicken.com> writes:

  > Does anyone see any problem?

Not exactly a problem, but isn't the preferred style for the
auto-mode-alist regexp to use \\' instead of $ ? 

What's the latest on the policy for adding stuff to auto-mode-alist and
interpreter-mode-alist?  Should it go in files.el or be autoloaded?

Not ruby related, but given we are talking about auto-mode-alist:
shouldn't nxml be added to it somehow?

Re: Ruby mode added

[Will Farrington]

I'm unsure of the policy but whatever it is it should be consistent.

On Dec 10, 2008, at 2:24 PM, Dan Nicolaescu <dann@ics.uci.edu> wrote:

> Chong Yidong <cyd@stupidchicken.com> writes:
>
>> Does anyone see any problem?
>
> Not exactly a problem, but isn't the preferred style for the
> auto-mode-alist regexp to use \\' instead of $ ?
>
> What's the latest on the policy for adding stuff to auto-mode-alist  
> and
> interpreter-mode-alist?  Should it go in files.el or be autoloaded?
>
> Not ruby related, but given we are talking about auto-mode-alist:
> shouldn't nxml be added to it somehow?
>
>

Re: Ruby mode added

[Paul R]

Hi folks,

Chong> Does anyone see any problem?

No problem at all, on the contrary I'm glad to see it bundled with
GnuEmacs and I hope that will speed up improvements and polishing of
this good mode. Thank to all who contributed to that.

-- 
  Paul

Re: Ruby mode added

[Chong Yidong]

Dan Nicolaescu <dann@ics.uci.edu> writes:

> Not exactly a problem, but isn't the preferred style for the
> auto-mode-alist regexp to use \\' instead of $ ? 

Yes, fixed.

> What's the latest on the policy for adding stuff to auto-mode-alist and
> interpreter-mode-alist?  Should it go in files.el or be autoloaded?

I have not thought about this issue.  Currently, both methods are in
use, but this is not enough of a problem to warrant attention.  Frankly,
there are many more urgent things to work on.

> Not ruby related, but given we are talking about auto-mode-alist:
> shouldn't nxml be added to it somehow?

We already have an xml-mode, which is more lightweight.  It may be that
nxml-mode is so much better that we should simply make it the default,
but I'd prefer to leave this decision till after the release.

(One reason not to make nxml-mode the default is that it is apparently
unmaintained.)

Re: Ruby mode added

[Stefan Monnier]

> - Removed the defun-region-command macro.  Is there a better way for
>   this file to remain XEmacs-compatible without this hack?

> (eval-when-compile
>   (defmacro defun-region-command (func args &rest body)
>     (let ((intr (car body)))
>       (when (featurep 'xemacs)
>         (if (stringp intr) (setq intr (cadr body)))
>         (and (eq (car intr) 'interactive)
>              (setq intr (cdr intr))
>              (setcar intr (concat "_" (car intr)))))
>       (cons 'defun (cons func (cons args body))))))

As mentioned earlier, an easy way is to rename it to
`ruby-defun-region-command'.


        Stefan

Re: Ruby mode added

[Stefan Monnier]

> Not exactly a problem, but isn't the preferred style for the
> auto-mode-alist regexp to use \\' instead of $ ? 

It's not a question of style: $ is usually incorrect, tho it will
usually work just fine in 99.99999% of the cases (very few files have
\n embedded in their name).

> What's the latest on the policy for adding stuff to auto-mode-alist and
> interpreter-mode-alist?  Should it go in files.el or be autoloaded?

I'm favorable to adding it via autoload as long as its order on the
auto-mode-alist is not important.


        Stefan

Re: Ruby mode added

[Dan Nicolaescu]

Chong Yidong <cyd@stupidchicken.com> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > 
  > We already have an xml-mode, which is more lightweight.  It may be that
  > nxml-mode is so much better that we should simply make it the default,
  > but I'd prefer to leave this decision till after the release.

Maybe this should be stated in NEWS...

Re: Ruby mode added

[Chong Yidong]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> As mentioned earlier, an easy way is to rename it to
> `ruby-defun-region-command'.

That's pretty ugly, tho.

Another possibility is to allow _ in the interactive spec (making it a
no-op).

Re: Ruby mode added

[Stefan Monnier]

>> As mentioned earlier, an easy way is to rename it to
>> `ruby-defun-region-command'.

> That's pretty ugly, tho.

I don't think so.  It's a special macro for ruby-mode, so it uses the
"ruby-" prefix.  Seems just plain normal.


        Stefan

Re: Ruby mode added

[Dan Nicolaescu]

Chong Yidong <cyd@stupidchicken.com> writes:

  > Does anyone see any problem?

This:

;;;###autoload
(add-to-list 'interpreter-mode-alist '("ruby" . ruby-mode))
(add-to-list 'interpreter-mode-alist '("rbx" . ruby-mode))
(add-to-list 'interpreter-mode-alist '("jruby" . ruby-mode))
(add-to-list 'interpreter-mode-alist '("ruby1.9" . ruby-mode))
(add-to-list 'interpreter-mode-alist '("ruby1.8" . ruby-mode))

autoloads a single item, not all of them.

Re: Ruby mode added

[Phil Hagelberg]

Chong Yidong <cyd@stupidchicken.com> writes:

> - There seemed to be a reference to an unbound variable, `indent-point',
>   in ruby-parse-partial.  I assumed this was an attempt to use dynamic
>   scope to access the let-bound variable `indent-point' in
>   ruby-calculate-indent; therefore I renamed indent-point as
>   ruby-indent-point and added a `boundp' check.  Phil, could you check
>   if this is the intention of the code?

Sorry for the late reply. I'm pretty sure this is correct.

I will notify ruby-core so they know that the code has been added to
Emacs' repository.

-Phil