unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion'.
Date: Sun, 05 May 2013 21:18:58 -0400	[thread overview]
Message-ID: <jwvip2wkj3q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <51861D6D.8030709@yandex.ru> (Dmitry Gutov's message of "Sun, 05 May 2013 12:50:53 +0400")

>>>> ;; (defun company-my-backend (command &optional arg &rest ignored)
>>>> -;;   (case command
>>>> -;;     (prefix (when (looking-back "foo\\>")
>>>> +;;   (pcase command
>>>> +;;     (`prefix (when (looking-back "foo\\>")
>>>> ;;               (match-string 0)))
>>>> -;;     (candidates (list "foobar" "foobaz" "foobarbaz"))
>>>> -;;     (meta (format "This value is named %s" arg))))
>>>> +;;     (`candidates (list "foobar" "foobaz" "foobarbaz"))
>>>> +;;     (`meta (format "This value is named %s" arg))))
>>> Like the header in company.el says, we still try to support Emacs 22 and
>>> 23. `pcase' was only added in 23.3, I believe.
>> But this is in a comment, so it's not a problem.
> I'm not sure recommending to users to write new backends in a way
> incompatible with older Emacs is good.

It is in my interest to encourage all users to move to a more
recent Emacs.  And even more so to encourage them to move away from `cl'
(which will be a long and arduous path, so every bit helps).

> I guess I'll remove `(init nil)', then.
> By the way, if you think that `init' is useless for all backends, I don't
> believe that's true for `ropemacs' and `clang'. Retrying initialization once
> per buffer is fairly useful.

There are many ways to do initialization in the backend (once per
session, once per buffer, once per blue moon, you name it) without using
`init'.

>> `completion-extra-properties' can have anything you want in it.
>> Same for `completion-metadata'.  Of course, new entries in these
>> alists/plists won't be understood by other users of
>> completion-at-point-functions, but that's not a problem in itself.
> Ah okay, so I guess that section has everything to do with moving some
> company backends to completion-at-point functions.

Very much so, yes.

> This is totally fine for `company-capf', but `company-begin-with' is an old
> function/feature.

But I'm only suggesting to change it in more recent versions of Company,
so it won't affect old users.


        Stefan



  parent reply	other threads:[~2013-05-06  1:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1UW5x9-0001hw-8W@vcs.savannah.gnu.org>
2013-05-04 21:59 ` /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion' Dmitry Gutov
2013-05-05  6:32   ` Stefan Monnier
2013-05-05  8:50     ` Dmitry Gutov
2013-05-05 10:05       ` Sebastian Wiesner
2013-05-05 10:13         ` Dmitry Gutov
2013-05-06  1:18       ` Stefan Monnier [this message]
2013-05-06  2:43         ` Dmitry Gutov
2013-05-06  3:22           ` Stefan Monnier
2013-05-09 20:35             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvip2wkj3q.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).