From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: debugger-toggle-locals Date: Sun, 01 Dec 2013 17:47:31 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385938067 7172 80.91.229.3 (1 Dec 2013 22:47:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Dec 2013 22:47:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 01 23:47:52 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VnFnr-0003i9-GD for ged-emacs-devel@m.gmane.org; Sun, 01 Dec 2013 23:47:51 +0100 Original-Received: from localhost ([::1]:33131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnFnq-00035A-VO for ged-emacs-devel@m.gmane.org; Sun, 01 Dec 2013 17:47:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnFng-00034t-0A for emacs-devel@gnu.org; Sun, 01 Dec 2013 17:47:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnFnY-000648-Gt for emacs-devel@gnu.org; Sun, 01 Dec 2013 17:47:39 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:10011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnFnY-000644-Cw for emacs-devel@gnu.org; Sun, 01 Dec 2013 17:47:32 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCox4/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOIYYl5kiCBXoMV X-IPAS-Result: Av4EABK/CFFMCox4/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOIYYl5kiCBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="40861467" Original-Received: from 76-10-140-120.dsl.teksavvy.com (HELO pastel.home) ([76.10.140.120]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 01 Dec 2013 17:47:31 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 6741D60CCE; Sun, 1 Dec 2013 17:47:31 -0500 (EST) In-Reply-To: (Helmut Eller's message of "Sat, 23 Nov 2013 09:57:17 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165994 Archived-At: > x: 9 > y: 114 > z: (9 . 114) Nitpick: I'd rather have "x=" instead of "x:" (for me, ":" means "has type"). > +(defun debugger--backtrace-base () > + "Return the function name that marks the top of the backtrace. > +See `backtrace-frame'." > + (cond ((eq 'debug--implement-debug-on-entry > + (cadr (backtrace-frame 1 'debug))) > + 'debug--implement-debug-on-entry) > + (t 'debug))) Please use it in debugger-eval-expression as well. > +(defun debugger--locals-visible-p () > + "Are the local variables of the current stack frame visible?" > + (save-excursion > + (move-to-column 2) > + (get-text-property (point) 'debugger-locals-visible-p))) The text property shouldn't have a name that ends in `-p'; these names are for predicates (i.e. functions returning a boolean), not for variables or object fields, or symbol/text properties. > + (dolist (s+v locals) > + (let ((symbol (car s+v)) > + (value (cdr s+v)) You can use (pcase-dolist (`(,symbol . ,value) locals) ...). > + (cond ((string= (symbol-name symbol) "internal-interpreter-environment") > + (cond ((or (null value) > + (and (null (cdr value)) > + (symbol (car value)))) ^^^^^^ should be `symbolp', right? `value' can also be of the form (a b t). I.e. (null (cdr value)) is false, but there are no values. But I tend to think that the handling of internal-interpreter-environment should be kept in the C code: this symbol should by and large not be exported to Elisp. > + backtrace_eval_unrewind (distance); [...] > + /* restore values from specpdl to orignal place */ > + backtrace_eval_unrewind (-distance); It's kind of annoying that we have to modify the backtrace in order to build the result, since the function is otherwise side-effect-free. It's admittedly simpler to do it as above rather than "doing it right". Stefan