From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115470: eww: exit and close actions Date: Thu, 12 Dec 2013 17:14:28 -0500 Message-ID: References: <87haadq3pn.fsf@flea.lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386886485 19920 80.91.229.3 (12 Dec 2013 22:14:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Dec 2013 22:14:45 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 12 23:14:50 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VrEWw-0000UH-EY for ged-emacs-devel@m.gmane.org; Thu, 12 Dec 2013 23:14:50 +0100 Original-Received: from localhost ([::1]:38809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrEWv-0005Ed-Sw for ged-emacs-devel@m.gmane.org; Thu, 12 Dec 2013 17:14:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrEWl-0005D0-Cw for emacs-devel@gnu.org; Thu, 12 Dec 2013 17:14:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrEWe-0007ew-3Y for emacs-devel@gnu.org; Thu, 12 Dec 2013 17:14:39 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:45276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrEWd-0007ep-T7 for emacs-devel@gnu.org; Thu, 12 Dec 2013 17:14:32 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBCMETBU002111; Thu, 12 Dec 2013 17:14:30 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 5EE0BAE350; Thu, 12 Dec 2013 17:14:28 -0500 (EST) In-Reply-To: <87haadq3pn.fsf@flea.lifelogs.com> (Ted Zlatanov's message of "Thu, 12 Dec 2013 14:17:08 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4790=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4790> : inlines <317> : streams <1089817> : uri <1622195> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166355 Archived-At: > I think `close' and `exit' in the context of a web browser are very > clear concepts. But they don't map cleanly to the use of eww, i.e. with Emacs. > Do you think any users are unfamiliar with web browsers? I think all users of eww are first and foremost Emacs users rather than "browser users" (at least for foreseeable future), so they will be familiar with quit-window and with the notion of killing a buffer, whereas they won't know (without looking at the code) whether `close' actually kills the buffer, or deletes the window, or both, or whether it's eww-exit which does it, and in which cases. > Or do you want to give Emacs-specific names to these concepts? Your commands don't really do what they do in a web-browser. I guess in some case, depending on how you look at it, and how you configured your display-buffer-alist and your dedicated windows, and how you started ewww, etc... they may occasionally behave similarly to Firefox's "close" and "exit" (tho it also depends on the window-manager in which you run firefox). But in the general case they don't. SM> I'm not sure how (setq eww-history nil) fits in there, because I don't SM> know why it's there, so I can't comment on how best to go about it in SM> this respect. > It ensures that the browsing history is erased, That part was clear, the question is why do it here rather than elsewhere. > which `kill-buffer' may not do. Why not? If the variable is buffer-local, kill-buffer will do it, and if the variable is global, then we have a problem since it's then shared between all eww buffers, right? Stefan