From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115918: package.el: various fixes. Date: Wed, 08 Jan 2014 09:16:39 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389190638 16420 80.91.229.3 (8 Jan 2014 14:17:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Jan 2014 14:17:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Bastien Guerry Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 08 15:17:24 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0twP-00062k-MU for ged-emacs-devel@m.gmane.org; Wed, 08 Jan 2014 15:17:05 +0100 Original-Received: from localhost ([::1]:46964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0twP-000553-6s for ged-emacs-devel@m.gmane.org; Wed, 08 Jan 2014 09:17:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0twF-00053w-BP for emacs-devel@gnu.org; Wed, 08 Jan 2014 09:17:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0tw8-0002e6-2t for emacs-devel@gnu.org; Wed, 08 Jan 2014 09:16:55 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:60205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0tw0-0002dO-9Z; Wed, 08 Jan 2014 09:16:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxKG9/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCTBLZEKA4hhiXoDkhyBXoMV X-IPAS-Result: Av8EABK/CFFFxKG9/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCTBLZEKA4hhiXoDkhyBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="44463639" Original-Received: from 69-196-161-189.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.189]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 Jan 2014 09:16:39 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 9112B606B5; Wed, 8 Jan 2014 09:16:39 -0500 (EST) In-Reply-To: (Bastien Guerry's message of "Wed, 08 Jan 2014 11:20:16 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167728 Archived-At: > @@ -881,13 +881,14 @@ > "Return true if PACKAGE, of MIN-VERSION or newer, is installed. > MIN-VERSION should be a version list." > (unless package--initialized (error "package.el is not yet initialized!")) > + (when (assq package package-alist) > (or > (let ((pkg-descs (cdr (assq package package-alist)))) > (and pkg-descs > (version-list-<= min-version > (package-desc-version (car pkg-descs))))) > ;; Also check built-in packages. > - (package-built-in-p package min-version))) > + (package-built-in-p package min-version)))) Could you explain in which circumstance you found this necessary? This might point to a problem elsewhere, Stefan