From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r116230: Fix bug #16558 with w32-shell-execute on remote file names. Date: Mon, 03 Feb 2014 22:39:30 -0500 Message-ID: References: <83ob2q4nbv.fsf@gnu.org> <83k3de41sc.fsf@gnu.org> <83iosx4iid.fsf@gnu.org> <83txcg3fle.fsf@gnu.org> <83lhxs2mru.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1391485190 16862 80.91.229.3 (4 Feb 2014 03:39:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Feb 2014 03:39:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 04 04:39:57 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WAWrc-0001bd-TW for ged-emacs-devel@m.gmane.org; Tue, 04 Feb 2014 04:39:57 +0100 Original-Received: from localhost ([::1]:50562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAWrc-0000Np-7a for ged-emacs-devel@m.gmane.org; Mon, 03 Feb 2014 22:39:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAWrS-0000NU-7T for emacs-devel@gnu.org; Mon, 03 Feb 2014 22:39:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAWrK-0006mv-UM for emacs-devel@gnu.org; Mon, 03 Feb 2014 22:39:46 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAWrD-0006lX-8p; Mon, 03 Feb 2014 22:39:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLyZ/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSQuh3AGwS2OLoJcA4hhnBmBXoJqKw X-IPAS-Result: Av4EABK/CFFFxLyZ/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSQuh3AGwS2OLoJcA4hhnBmBXoJqKw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="46722028" Original-Received: from 69-196-188-153.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.153]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Feb 2014 22:39:30 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 7100660335; Mon, 3 Feb 2014 22:39:30 -0500 (EST) In-Reply-To: <83lhxs2mru.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Feb 2014 18:17:57 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169378 Archived-At: >> I guess the question for me now is "why call Fexpand_file_name"? [...] >> But I don't know which problem it was trying to solve. > The problem happened when using a function in shr.el that no longer > exists. To recreate that, I'd need to restore that function and trace > through that. The result I do remember: w32-shell-execute failed > because DOCUMENT was a non-absolute file name, but not in the > directory where the function expected it to be. So maybe the simplest solution is to remove this call to expand-file-name. I suspect that if expand-file-name is needed it can always be called before entering w32-shell-execute. Stefan