unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Eli Zaretskii <eliz@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] trunk r117941: Default to stack objects on non-GNU/Linux, non-DOS_NT platforms.
Date: Thu, 25 Sep 2014 14:12:53 -0400	[thread overview]
Message-ID: <jwviokb1smu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <54243ED1.4060708@yandex.ru> (Dmitry Antipov's message of "Thu, 25 Sep 2014 20:12:01 +0400")

>> IIUC the point of this new code is to improve performance
> Yes.  I should say that I've seen small but stable improvements before
> r117942,

It'd be good to see actual numbers.  I know that the performance
benefits for "average editing" is going to be negligible and I can live
with that, but I do want to see at least some real-use scenarios where
the benefit is tangible.

> but adding extra precautions against stack overflow makes
> them really negligible.  This means that we're going to an
> overengineered feature with no benefits.

I'm glad you feel that way.  When I saw this extra checking in
local_cons, I figured this is going to kill too much of the
performance gain.

> IMO we should make it fast rather than commonly used.

Right: the extra checks shouldn't fallback to Fcons but should
`abort' instead.


        Stefan



  reply	other threads:[~2014-09-25 18:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  8:15 [Emacs-diffs] trunk r117941: Default to stack objects on non-GNU/Linux, non-DOS_NT platforms Eli Zaretskii
2014-09-25  9:51 ` Dmitry Antipov
2014-09-25 10:14   ` Eli Zaretskii
2014-09-25 12:52   ` Stefan Monnier
2014-09-25 16:12     ` Dmitry Antipov
2014-09-25 18:12       ` Stefan Monnier [this message]
2014-09-25 19:08         ` Paul Eggert
2014-09-25  9:52 ` Eli Zaretskii
2014-09-25 16:06 ` Paul Eggert
2014-09-25 16:48   ` Eli Zaretskii
2014-09-25 18:46     ` Paul Eggert
2014-09-25 19:16       ` Eli Zaretskii
2014-09-25 20:56         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwviokb1smu.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dmantipov@yandex.ru \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).