From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: [Emacs-diffs] master f7572b7: Fix Semantic completion-at-point functions in non-Semantic buffers
Date: Sun, 14 Dec 2014 09:30:14 -0500 [thread overview]
Message-ID: <jwviohemhm3.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1Y06tt-0002BU-21@vcs.savannah.gnu.org> (Dmitry Gutov's message of "Sun, 14 Dec 2014 10:59:45 +0000")
> * lisp/cedet/semantic.el (semantic-analyze-completion-at-point-function)
> (semantic-analyze-notc-completion-at-point-function)
> (semantic-analyze-nolongprefix-completion-at-point-function): Do
> nothing if the current buffer is not using Semantic.
Looks like the wrong fix. Don't you think the right fix would be to
change the add/remove-hooks in semantic-mode so that they are
buffer-local?
Stefan
next parent reply other threads:[~2014-12-14 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141214105944.8359.64300@vcs.savannah.gnu.org>
[not found] ` <E1Y06tt-0002BU-21@vcs.savannah.gnu.org>
2014-12-14 14:30 ` Stefan Monnier [this message]
2014-12-14 14:38 ` [Emacs-diffs] master f7572b7: Fix Semantic completion-at-point functions in non-Semantic buffers Dmitry Gutov
2014-12-14 22:51 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviohemhm3.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).