From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Daniel Colascione <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior
Date: Tue, 05 May 2015 13:48:08 -0400 [thread overview]
Message-ID: <jwvioc6yl17.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <5547F4BB.1080804@dancol.org> (Daniel Colascione's message of "Mon, 04 May 2015 15:37:47 -0700")
> It is always a marker, isn't it?
I think so, yes.
> Some other parts of simple.el assume it always returns non-nil.
> I'll remove the nil check.
Good, thanks.
>> IIUC activate-mark-hook should also be run when (eq omark nmark) but
>> cur-mark-active was nil.
> Huh. I just mechanically translated the original save-excursion C code.
Ah, you're probably right: the save-excursion code had such kinds of problems.
> I'll change the code to match the comment.
Thanks,
Stefan
next prev parent reply other threads:[~2015-05-05 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150504184829.1108.13525@vcs.savannah.gnu.org>
[not found] ` <E1YpLPp-0000IV-4c@vcs.savannah.gnu.org>
2015-05-04 22:16 ` [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior Stefan Monnier
2015-05-04 22:37 ` Daniel Colascione
2015-05-05 17:48 ` Stefan Monnier [this message]
2015-05-04 23:02 ` Nicolas Petton
2015-05-04 23:04 ` Daniel Colascione
2015-05-05 17:50 ` Stefan Monnier
2015-05-05 18:04 ` Daniel Colascione
2015-05-05 19:00 ` Stefan Monnier
2015-05-05 18:31 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvioc6yl17.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).