From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master da4ce83: * nt/INSTALL: Update instructions for running autogen.sh
Date: Fri, 02 Oct 2015 11:50:54 -0400 [thread overview]
Message-ID: <jwvio6pl1b8.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <83vbap5qkf.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Oct 2015 16:48:48 +0300")
> if test -d .git; then
>
> # Configure 'git diff' hunk header format.
>
> git config 'diff.elisp.xfuncname' \
> '^\(def[^[:space:]]+[[:space:]]+([^()[:space:]]+)' || exit
> git config 'diff.texinfo.xfuncname' \ ^^^^^^^
> '^@node[[:space:]]+([^,[:space:]][^,]+)' || exit
> ^^^^^^^
>
> It exits with an error message, which in my book means it "fails".
Hmm... I see.
So the "test -d .git" ensures that this code is only run when Git was
used to get the code, so we can reasonably assume that Git is (still)
available. I understand your text better now, thanks.
Still, I think the above code is making a poor choice. Better emit the
warning and keep on going: these "git config" settings are sufficiently
important to justify aborting the whole operation, IMO.
Stefan
next prev parent reply other threads:[~2015-10-02 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151002085648.25296.22993@vcs.savannah.gnu.org>
[not found] ` <E1Zhw92-0006ag-Df@vcs.savannah.gnu.org>
2015-10-02 13:03 ` [Emacs-diffs] master da4ce83: * nt/INSTALL: Update instructions for running autogen.sh Stefan Monnier
2015-10-02 13:48 ` Eli Zaretskii
2015-10-02 15:50 ` Stefan Monnier [this message]
2015-10-02 17:55 ` Eli Zaretskii
2015-10-02 19:43 ` Paul Eggert
2015-10-02 21:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvio6pl1b8.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).