unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Reuben Thomas <rrt@sc3d.org>
Subject: Re: [Emacs-diffs] master 690512d: Fix a FIXME with an exegetical comment
Date: Fri, 25 Aug 2017 17:02:15 -0400	[thread overview]
Message-ID: <jwvinhb4b2q.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20170825125953.D61F420EC0@vcs0.savannah.gnu.org> (Reuben Thomas's message of "Fri, 25 Aug 2017 08:59:53 -0400 (EDT)")

>      (wksh sh-append ksh88
> -          ;; FIXME: This looks too much like a regexp.  --Stef
> +          ;; wksh has X toolkit APIs as built-ins!
>  	  "Xt[A-Z][A-Za-z]*")

But AFAICT sh-builtins is passed to `regexp-opt', so the above will
simply treat the command with name "Xt[A-Z][A-Za-z]*" as a builtin,
instead of recognizing any command that matches this regexp.


        Stefan



       reply	other threads:[~2017-08-25 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170825125953.23848.98653@vcs0.savannah.gnu.org>
     [not found] ` <20170825125953.D61F420EC0@vcs0.savannah.gnu.org>
2017-08-25 21:02   ` Stefan Monnier [this message]
2017-08-25 21:20     ` [Emacs-diffs] master 690512d: Fix a FIXME with an exegetical comment Reuben Thomas
2017-08-26  7:41       ` Eli Zaretskii
2017-08-26  8:02         ` Reuben Thomas
2017-08-26  8:10         ` Paul Eggert
2017-08-26 23:29           ` Reuben Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvinhb4b2q.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rrt@sc3d.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).