From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Flymake support for C/C++ Date: Fri, 01 Jun 2018 18:08:08 -0400 Message-ID: References: <87zi8wmmhw.fsf@gmail.com> <20171012175044.GA6106@ACM> <87tvz4mcg3.fsf@gmail.com> <20171012203953.GB6106@ACM> <87infkm53o.fsf@gmail.com> <20180601210708.GA6771@ACM> <87in72p3yq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1527890780 12718 195.159.176.226 (1 Jun 2018 22:06:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 1 Jun 2018 22:06:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Alan Mackenzie , eliz@gnu.org, npostavs@users.sourceforge.net, sdl.web@gmail.com, emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 02 00:06:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOsBb-0003Bt-FU for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2018 00:06:15 +0200 Original-Received: from localhost ([::1]:57660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOsDg-00070E-Hj for ged-emacs-devel@m.gmane.org; Fri, 01 Jun 2018 18:08:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOsDZ-0006zM-2k for emacs-devel@gnu.org; Fri, 01 Jun 2018 18:08:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOsDT-0002eJ-V5 for emacs-devel@gnu.org; Fri, 01 Jun 2018 18:08:16 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:41448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOsDT-0002Xi-KE; Fri, 01 Jun 2018 18:08:11 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w51M8WoL027159; Fri, 1 Jun 2018 18:08:32 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 9B4E965439; Fri, 1 Jun 2018 18:08:08 -0400 (EDT) In-Reply-To: <87in72p3yq.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Fri, 01 Jun 2018 22:54:53 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6299=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6299> : inlines <6676> : streams <1788463> : uri <2651045> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225905 Archived-At: >> As do flyspell, compile mode, trailing space mode (or whatever it's >> called), #ifdef mode (or whatever that's properly called), and any >> number of other minor modes. None of them make an appearance in the CC >> Mode source code, but are frequently enabled in major mode hooks. >> outline.el doesn't either. > > I was merely pointing out that a brief "flymake" appearance in > cc-mode.el would hardly be an exception. Of course Emacs has so many > other parts that some of them are bound to not appear in cc-mode :-). Also note that most of those that don't appear in cc-mode are modes which don't really need to be tweaked based on the buffer's language. > We can, but I believe c-mode-common-hook in particular should be a > pristine nil after Emacs -Q. Agreed. > Perhaps I am mistaken and it's not that common a practice, but all the > major modes flymake has entered in have followed the same guideline. CC-mode is not just another major mode ;-) Stefan