From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Failing to GC killed buffers considered harmful Date: Tue, 31 Mar 2020 17:57:08 -0400 Message-ID: References: <838sjj5jg9.fsf@gnu.org> <83sgho1uqr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18810"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: pipcet@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 31 23:58:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJOtg-0004pS-1S for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 23:58:12 +0200 Original-Received: from localhost ([::1]:44518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJOtf-0004WX-33 for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 17:58:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41549) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJOsl-000466-Sc for emacs-devel@gnu.org; Tue, 31 Mar 2020 17:57:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJOsk-000747-Bt for emacs-devel@gnu.org; Tue, 31 Mar 2020 17:57:15 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19731) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJOsi-0006tj-Em; Tue, 31 Mar 2020 17:57:12 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 90A61100E35; Tue, 31 Mar 2020 17:57:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 14CB9100E90; Tue, 31 Mar 2020 17:57:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1585691830; bh=MsC5RRXDfOdh9Ifr+wZB/eAWFOiajvOmMYCenxyNV34=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cgiW1I7JX+sdOHvOCQfcCQQDz2oPRmvkO0huFcU+9jp87Hhv6ESCXOAyjS956YTN2 d7aBBSSN7HjHQYHrbHCn+Mb/bwrdlvBYJw/R9LMQ8V2BaXHUUcpl9MnQE+yFyZkWcM Sb+OtN+DRc0MBr+DeR8uTtS+6hh4oe/bF4sQjkrwqiHDBZCuPLcI/Rd6XoT/3ju1K6 tmXl7pVoTR9Lkrk5ADYy/sVFBrL6LWWYu9xVl3e57a97QLg+Wzpk4vXqrnwhrvKkjL dmRIvNd1OPL0DjsMz49RgzTsxmCfTD6Zr5DtN+xoelD56uBehqsGp/cOogASiN5suX K7bJG1b/lUpCg== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A9BBE1206E3; Tue, 31 Mar 2020 17:57:09 -0400 (EDT) In-Reply-To: <83sgho1uqr.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 31 Mar 2020 17:09:32 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246161 Archived-At: >> Not sure why buffers would be more likely to have valid pointers into >> them (and can't remember discussions about that either) > > Pointers to buffer text come to mind. In the mean time Pip pointed out that I was confused: pointrs into the middle of pseudovectors are handled just as well, so it's a non-issue. >> - if (!pdumper_object_p (buffer)) >> - XUNMARK_VECTOR (buffer); > Why is this part being removed? Because this is handled by the sweep_vectors code. Stefan