From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Imports / inclusion of s.el into Emacs Date: Fri, 01 May 2020 14:09:43 -0400 Message-ID: References: <266155d4-f9c0-8ed3-8df5-32feea171076@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="1113"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Philippe Vaucher , Emacs developers , Dmitry Gutov To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 01 20:11:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUa7w-0000B1-4K for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 20:11:08 +0200 Original-Received: from localhost ([::1]:48718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUa7v-0001n6-5y for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 14:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUa7A-0000jb-JI for emacs-devel@gnu.org; Fri, 01 May 2020 14:10:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUa6e-0003Bm-If for emacs-devel@gnu.org; Fri, 01 May 2020 14:10:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUa6e-00039y-2E for emacs-devel@gnu.org; Fri, 01 May 2020 14:09:48 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9720880D86; Fri, 1 May 2020 14:09:46 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BD345814DB; Fri, 1 May 2020 14:09:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1588356584; bh=2V/kuuSCmaOcTLfNBbsbYOZdkrTE78TMFjs28oMnTqk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=JLLWr5nIWmqGqP+XyjahosgctLZ3OnuG1dz1Yv7gqQsr4h8unYKK+SwF4d2TRWdbv ESKkIqgHhvUtvcmf4oNn3eV53059wu8D7B9wM0MGqf5C+ynYG4qYWKwPhYyYZ2AOrW OUJ4RSOVGGJek+VTVBPBSFvjU0+vLAO7OaqWoUyzxMLSuVIB703OuEWBl7c+GrDHab Wcv6X6nTmanlp+P8PUMVv7TLIXm7T3dKcOrjA+dzZ+zoXxk0KvWDk8wLAH88Azg555 ylwLwp1H8IP4gYCIBlwq1QDferW41+voF62E978NkI51uj64P53jf15tYbfQ5SBeyJ 57PcQdaMPUJ+g== Original-Received: from alfajor (unknown [216.154.3.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 434D91206EB; Fri, 1 May 2020 14:09:44 -0400 (EDT) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Fri, 1 May 2020 18:28:51 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/01 11:55:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248327 Archived-At: > Just wanted to voice my support for exactly the points that Dmitry makes. > And if we do add it to Elpa, can we give it a slightly longer prefix? Like > 'cljstr`? I don't think renaming it will fly. We should definitely add it to GNU ELPA because it's used by many other Elisp packages. But renaming would be self-defeating some all those packages won't want to go through the renaming. But for Emacs itself, we could probably rename some existing functions to use the `string-` prefix and maybe incorporate some ideas from s.el (I haven't looked very much into it, so I have no idea how much there is to incorporate, but I assume there are some good ideas). Stefan > On Fri, May 1, 2020, 18:21 Dmitry Gutov wrote: > >> On 01.05.2020 17:56, Philippe Vaucher wrote: >> > Following our discussion about namespace I think it's time to start with >> > something concrete where most people are agreeing already >> >> FWIW, I made a couple of other suggestions. >> >> As far as s.el goes, I suppose it might be a good thing to add it to >> ELPA for those who like it. >> >> I'm not completely sold on its contents for the core, however: a lot of >> it looks like a compatibility layer for Clojure's familiarity's sake, >> with very thin wrappers (which basically just add the cost of function >> invocation). >> >> Examples: >> >> 1. s-prepend/s-append: trivially replaced by 'concat'. >> >> 2. s-trim: string-trim is already in subr-x. >> >> 3. s-split: basically delegates to split-string, but wraps it in >> save-match-data (which is generally against our guidelines for its use). >> >>