From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: scratch/command 064f146 1/2: Change command to interactive ... modes Date: Wed, 17 Feb 2021 16:03:39 -0500 Message-ID: References: <20210213141225.11309.86562@vcs0.savannah.gnu.org> <20210213141226.EEDFE20999@vcs0.savannah.gnu.org> <47209379-76df-4c97-e5ff-b3b04da0db1d@yandex.ru> <87zh07of0e.fsf@gnus.org> <0605ed62-a785-d190-caf2-2232e1db3b0f@yandex.ru> <87mtw6d480.fsf@gnus.org> <87eehid3k2.fsf@gnus.org> <87r1liblzb.fsf@gnus.org> <87czwy1mu2.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21892"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Stefan Kangas , Dmitry Gutov To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 17 22:41:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCUZk-0005aD-Uz for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 22:41:36 +0100 Original-Received: from localhost ([::1]:55600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCUZk-0003MM-0G for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 16:41:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCTz7-0007u5-Bc for emacs-devel@gnu.org; Wed, 17 Feb 2021 16:03:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6094) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCTz5-0001Wd-GN for emacs-devel@gnu.org; Wed, 17 Feb 2021 16:03:44 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9A34610020E; Wed, 17 Feb 2021 16:03:42 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E8798100018; Wed, 17 Feb 2021 16:03:40 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1613595820; bh=s3hn3m7swRRS15neTUfIXoYe+V9NhRRhssSYfaBQcvY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KB2jJLgpZn8fuvF921XHBAWEQCNtAW1HAVejEnikx472jxMOYIQNOv4oxFxc2yIGC q5feRpFXiwYJLIx1piEffs9OjEdXTDa3BNkLP8KrPX1nq6ulkvh+CVfVp36kOGIP2z ngtuCB5HIbeTEbQSdCRMuaYpuqdOGWKqoawdYYGmPTA0uCs9Zx2EKa3g+txf0En+/6 qq5RtNJkktlQrLS7nvdIYgr6jQq7h4OVU0NPWdFkKBsL11x+WXABnmnJd1GX6hhDrc 07uDLrKzJeVmR04F1krqgz3qeSm57ksTNq0Po1GaaJ/1VVLJQOL+zH/ZAiav5LdNo0 arWILikzOAASw== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B3F7E1203B2; Wed, 17 Feb 2021 16:03:40 -0500 (EST) In-Reply-To: <87czwy1mu2.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 17 Feb 2021 21:05:57 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265089 Archived-At: >> Please find attached a patch. > Hm... trying this out now, I don't think the compat macro solution > actually works. That is, it works fine when byte-compiled, but not in > non-compiled code. The reason for this is that `interactive-form' just > does a `Fassq' on the Lisp form and looks for the Qinteractive symbol. > Which is won't find if the symbol in `future-interactive'. As I said, I think it will work whenever the code has been fully macro-expanded, which happens not just for byte-compilation but also for `eval-buffer`, or when loading a `.el` file. We should arguably do it at most other occasions (e.g. `C-M-x`), but someone will have to write the corresponding patches. Stefan